hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Feb 2023
7:55 am

Michael Garthwaite

Merge branch 'staging' into DEN-14589-DIAL-211

Options
    • -44
    • +23
    ./Controllers/PresOccl.c
    • -6
    • +15
    ./Controllers/SyringePump.c
    • -3
    • +3
    ./Services/SystemComm.c
    • -14
    • +33
    ./Services/SystemCommMessages.c
    • -3
    • +6
    ./Services/SystemCommMessages.h
Monday 06 Feb 2023
4:26 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:12 pm

Michael Garthwaite

it was a double include anyway. Fixed. Thanks!

it was a double include anyway. Fixed. Thanks!

2:12 pm

Michael Garthwaite

DEN-14547: Addressing code review

Options
    • -1
    • +0
    ./Modes/PreTreatmentRecirc.c
1:50 pm

wbracken  (deleted user)

Alphabetical ordering.

Alphabetical ordering.

1:45 pm

Michael Garthwaite

Merge branch 'staging' into DEN-14547-incorrect-dg-event

Options
    • -7
    • +33
    ./Modes/PreTreatmentRecirc.c
1:27 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
1:15 pm

Sean Nash

Fixed merge conflicts.

Options
    • -1
    • +1
    ./Controllers/BloodFlow.c
    • -2
    • +2
    ./Controllers/DGInterface.c
    • -2
    • +2
    ./Controllers/DGInterface.h
    • -2
    • +2
    ./Controllers/PresOccl.c
    • -4
    • +13
    ./Controllers/SyringePump.c
    • -1
    • +1
    ./Drivers/Battery.c
    • -2
    • +2
    ./Modes/ConsumableSelfTest.c
    • -15
    • +15
    ./Modes/ModePreTreat.c
    • -2
    • +3
    ./Modes/ModeStandby.c
    • -2
    • +2
    ./Modes/ModeStandby.h
    • -2
    • +2
    ./Modes/Prime.c
    • -3
    • +3
    ./Modes/SelfTests.c
    • -2
    • +2
    ./Services/SystemComm.c
    • -2
    • +2
    ./Services/SystemCommMessages.c
    • -2
    • +2
    ./Services/SystemCommMessages.h
12:56 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
12:55 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/SyringePump.c
    • -2
    • +2
    ./Controllers/SyringePump.h
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/ModeTreatment.c
    • -1
    • +1
    ./Modes/SelfTests.c
    • -1
    • +1
    ./Services/AlarmMgmt.c
    • -0
    • +16
    ./Services/Reservoirs.c
12:54 pm

Sean Nash

12:18 pm

Darren Cox <darren_m@cox.net>

DEN-14561 Updated for code review comments.

Options
    • -1
    • +0
    ./Modes/ModePreTreat.c
    • -9
    • +8
    ./Services/AlarmMgmt.c
Sunday 05 Feb 2023
2:51 pm

Sean Nash

DEN-14749: Reset preload flag in standby mode instead of after retract/seek/prime operations. Increase alarm threshold for FMD vs. LC check in wet s.t. from 5% to 10%. Refactor alarm audio and 1 minute min tx time config flags. Removed test code in reservoir code.

Options
    • -3
    • +12
    ./Controllers/SyringePump.c
    • -0
    • +1
    ./Controllers/SyringePump.h
    • -0
    • +1
    ./Modes/ModeStandby.c
    • -15
    • +14
    ./Modes/ModeTreatment.c
    • -1
    • +1
    ./Modes/SelfTests.c
    • -2
    • +2
    ./Services/AlarmMgmt.c
    • -31
    • +7
    ./Services/Reservoirs.c
Saturday 04 Feb 2023
6:37 pm

Sean Nash

This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.

This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.

6:15 pm

Sean Nash

Friday 03 Feb 2023
3:05 pm

Darren Cox <darren_m@cox.net>

DEN-1561 Fix integrated volume calculation for reservoir transfers.

Options
    • -5
    • +2
    ./Modes/SelfTests.c
3:01 pm

Dara Navaei

HD-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
HD-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
3:01 pm

Dara Navaei

HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
2:01 pm

Dara Navaei

1:56 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
1:55 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/Voltages.c
1:02 pm

wbracken  (deleted user) and Sean Nash

12:48 pm

Dara Navaei

DEN-14604 added code to not trigger the AC power loss if the safefy shutdown is enabled

Options
    • -5
    • +9
    ./Controllers/Voltages.c
10:59 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:58 am

Michael Garthwaite

DEN-14589: fixed syringe pump events.

Options
    • -1
    • +1
    ./Controllers/SyringePump.c
9:47 am

Sean Nash

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds. Generalize the math. Suggested approach: -integrate vol...

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds.
Generalize the math.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

9:47 am

Sean Nash

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement bel...

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement below (now that transfer time was reduced to 30 sec).
Let's generalize this math to clarify it and make it work regardless of time.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

Thursday 02 Feb 2023
5:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.