firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8103: Updated fpga comm time out alarm name

DEN-7605: Added FPGA reported comm error to FPGA comm error check. Fixed persistent alarm periods in syringe pump module.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7605: Added more published data and overrides to syringe pump module.

    • -19
    • +288
    ./App/Controllers/SyringePump.c
    • -0
    • +128
    ./App/Services/SystemCommMessages.c
    • -0
    • +12
    ./App/Services/SystemCommMessages.h
DEN-8103: Added check for i2c nack and arbitration lost

DEN-7605: Addressed more code review comments.

Fixed.

Fixed.

Fixed.

Fixed.

Copy and paste error. Fixed.

Copy and paste error. Fixed.

DEN-7605: Addressed code review feedback.

Same as above.

Same as above.

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

These functions need doxygen description.

These functions need doxygen description.

I agree, but sometimes feel it helps readability.

I agree, but sometimes feel it helps readability.

Yes, you are right. I will use fwcommon code.

Yes, you are right. I will use fwcommon code.

Fixed.

Fixed.

What declaration?

What declaration?

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.