leahi-application / sources / gui / qml

pages

Clone Tools

Stats

Commits this week: 4
Total Committers: 6
Last Commit: 11 Dec
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Dec
1:43 am

Behrouz NematiPour

It is a little bit concerning: Could you please test/describe the following scenarios: *What if we have more than one Heparin type supported? *What if none (incorrectly) has been defined in the c...

It is a little bit concerning:
Could you please test/describe the following scenarios:

  • What if we have more than one Heparin type supported?
  • What if none (incorrectly) has been defined in the configuration (do we get an index out of bounds)?
1:39 am

Behrouz NematiPour

We will address this later on code modularizations. RESOLVED.

We will address this later on code modularizations.
RESOLVED.

Thursday 11 Dec
11:18 am

Nicholas Ramirez

LDT-3005 End of Treatment - SW - 01 - R&I - 05: DEV - Feature Implementation

cleanup

Options
    • -2
    • +0
    ./MainStack.qml
  2. … 1 more file in changeset.
10:33 am

Dara Navaei

LEAHI-APPLICATION-LDT-3000_End of Treatment - SW - 01 - R&I
LEAHI-APPLICATION-LDT-3000_End of Treatment - SW - 01 - R&I
10:28 am

Nicholas Ramirez

LDT-3005 End of Treatment - SW - 01 - R&I - 05: DEV - Feature Implementation

upload of code

Options
    • -1
    • +10
    ./MainStack.qml
    • -1
    • +1
    ./endtreatment/EndTreatmentEndStack.qml
    • -9
    • +0
    ./endtreatment/rinseback/EndTreatmentRinsebackInit.qml
    • -31
    • +29
    ./treatment/TreatmentHome.qml
    • -3
    • +5
    ./treatment/TreatmentSectionHeader.qml
    • -6
    • +6
    ./treatment/TreatmentStack.qml
    • -0
    • +2
    ./treatment/adjustments/TreatmentAdjustmentUltrafiltrationStart.qml
    • -3
    • +3
    ./treatment/sections/TreatmentFlows.qml
    • -5
    • +6
    ./treatment/sections/TreatmentTime.qml
  10. … 22 more files in changeset.
Wednesday 10 Dec
4:54 pm

Behrouz NematiPour

I believe any related view could have provided a timer since they are inherited from QObject. That is fine for now but consider using our C++ view codes for such a thing.

I believe any related view could have provided a timer since they are inherited from QObject.
That is fine for now but consider using our C++ view codes for such a thing.

4:50 pm

Behrouz NematiPour

Thank you .

Thank you .

4:46 pm

Nicholas Ramirez

pop(null) will unwind the stack and go back to main treatment. I tested and added a comment in code as well

pop(null) will unwind the stack and go back to main treatment. I tested and added a comment in code as well

4:45 pm

Nicholas Ramirez

LDT-2960 Heparin - SW - 01 - R&I - 03: SDD - Design Diagram - plantuml

adddress cr comment

Options
    • -2
    • +2
    ./treatment/TreatmentStack.qml
4:31 pm

Nicholas Ramirez

updated to statusColor

updated to statusColor

4:30 pm

Nicholas Ramirez

added

added

4:30 pm

Nicholas Ramirez

used for the 1 min user activity timeout to move back to main treatment from heparin.. Its a requirement LEAHI-PRS-666

used for the 1 min user activity timeout to move back to main treatment from heparin.. Its a requirement LEAHI-PRS-666

4:29 pm

Nicholas Ramirez

updated

updated

4:29 pm

Nicholas Ramirez

updated

updated

4:27 pm

Nicholas Ramirez

yes good catch. updated

yes good catch. updated

4:27 pm

Nicholas Ramirez

moved

moved

4:26 pm

Nicholas Ramirez

removed

removed

4:26 pm

Nicholas Ramirez

done

done

4:26 pm

Nicholas Ramirez

LDT-2960 Heparin - SW - 01 - R&I - 03: SDD - Design Diagram - plantuml

address cr comments

Options
    • -0
    • +355
    ./treatment/TreatmentHeparin.qml
    • -1
    • +0
    ./treatment/TreatmentStack.qml
    • -355
    • +0
    ./treatment/sections/TreatmentHeparin.qml
  4. … 6 more files in changeset.
3:59 pm

Behrouz NematiPour

Please align.

Please align.

3:56 pm

Behrouz NematiPour

Please use the mainTreatment screen as the default. If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

Please use the mainTreatment screen as the default.
If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

3:53 pm

Behrouz NematiPour

You no longer need this after you move the heparin screen from the sections folder.

You no longer need this after you move the heparin screen from the sections folder.

3:51 pm

Behrouz NematiPour

Shouldn't ""Unfractionated 1000"" come from the configurations?

Shouldn't ""Unfractionated 1000"" come from the configurations?

3:49 pm

Behrouz NematiPour

We should add the qsTr()

We should add the qsTr()

3:48 pm

Behrouz NematiPour

Move this outside of the sections folder, since it is no longer a section and has its own dedicated screen.

Move this outside of the sections folder, since it is no longer a section and has its own dedicated screen.

3:37 pm

Behrouz NematiPour

We should use "min" for minutes and not "mins". Same for "hrs" => "hr".

We should use "min" for minutes and not "mins".
Same for "hrs" => "hr".

3:28 pm

Behrouz NematiPour

What is this file used for? And please add a brief description for the file comment.

What is this file used for?
And please add a brief description for the file comment.

3:26 pm

Behrouz NematiPour

Please put comments for your division number.

Please put comments for your division number.

3:26 pm

Behrouz NematiPour

statusColor is so general, but is bound to the heparinStatusColor. Please either change the status color to be heparin only or change the heparinStatus Color name to be more general. The latter is ...

statusColor is so general, but is bound to the heparinStatusColor.
Please either change the status color to be heparin only or change the heparinStatus Color name to be more general.
The latter is better.

3:07 pm

Nicholas Ramirez

okay will do

okay will do