leahi_dialin

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fixed it

fixed it

LDT-2004 implementing code review comments + test config for drybicart initial fill test in pre-gen

This is a change from Zoltan and I am updated that into my local branch

This is a change from Zoltan and I am updated that into my local branch

Merge branch 'LDT-2994-iofp-valve-data-is-inaccurate' into staging

LDT-3173: msg ids for conductivity overrides

    • -0
    • +30
    ./dd/modules/conductivity_sensors.py
    • -0
    • +31
    ./fp/modules/conductivity_sensors.py
Merge branch 'LDT-2787-fp_dd_proxy_commands' into develop

Merge branch 'staging' into LDT-2787-fp_dd_proxy_commands

testconfig fix

Merge branch 'LDT-3350-add_from_str' into staging

LDT-3287: Reworked the initial message to be a login command instead of a blank ACK message

This class member is a way for dialin to present all the valve states in a list like so: >>> fp = FP() >>> fp.valves.valve_states_enum [0, 0, 0, 0, 0, 0, 0] It is organized in the order of the e...

This class member is a way for dialin to present all the valve states in a list like so:

>>> fp = FP()
>>> fp.valves.valve_states_enum
[0, 0, 0, 0, 0, 0, 0]


It is organized in the order of the enum that was used to iterate. This is purely for presentation / Quality of life feature for the dialin user. We can remove it if we know users are no longer using it for monitoring

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?