leahi-dialin / leahi_dialin

dd

Clone Tools

Stats

Commits this week: 11
Total Committers: 12
Last Commit: 04 Feb
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Feb
3:05 pm

Zoltan Miskolci

- Removed ignore and _str_list from base class, added empty _str_list to all childs to not throw an error when from_str is called on them

Options
    • -0
    • +1
    ./modules/blood_leak.py
  2. … 7 more files in changeset.
8:43 am

Zoltan Miskolci

Merge branch 'LDT-3350-add_from_str' into develop

Options
    • -2
    • +2
    ./modules/valves.py
  2. … 1 more file in changeset.
8:41 am

Zoltan Miskolci

Merge branch 'LDT-2994-iofp-valve-data-is-inaccurate' into develop

Options
    • -2
    • +6
    ./modules/valves.py
  2. … 1 more file in changeset.
8:40 am

Zoltan Miskolci

Merge branch 'LDT-2787-fp_dd_proxy_commands' into develop

Options
    • -2
    • +28
    ./modules/conductivity_sensors.py
    • -4
    • +0
    ./modules/gen_dialysate.py
  3. … 2 more files in changeset.
Tuesday 03 Feb
4:43 pm

Zoltan Miskolci

- Matching alarm publish name with variable name

Options
    • -1
    • +1
    ./modules/alarms.py
4:36 pm

Sean Nash and Zoltan Miskolci

4:35 pm

Zoltan Miskolci

- Updated test config names - Removed invalid publish from gen_dialysate

Options
    • -4
    • +0
    ./modules/gen_dialysate.py
  2. … 1 more file in changeset.
3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:54 pm

Behrouz NematiPour

This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

3:54 pm

Behrouz NematiPour

This is incorrect. We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use. We will keep it for now to unblock the rest of the...

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

3:30 pm

Vendor - TEL - Sameer Poyil , Zoltan Miskolci and Michael Garthwaite

2:27 pm

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

2:25 pm

Zoltan Miskolci

removed commented out line

removed commented out line

2:21 pm

Dara Navaei

LEAHI-DIALIN-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DIALIN-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
2:20 pm

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

2:20 pm

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

2:15 pm

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

2:12 pm

Zoltan Miskolci

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

2:10 pm

Zoltan Miskolci

Yes

Yes

2:05 pm

Zoltan Miskolci

Based on the msg id, it should be here

Based on the msg id, it should be here

2:03 pm

Vendor - TEL - Arpita Srivastava

LDT-3222: Updated function cmd_bc_valves_override to add reset parameter

Options
    • -5
    • +8
    ./modules/valves.py
1:59 pm

Zoltan Miskolci

- fixed valve_state_enums to be updated - Fixed balancing chamber broadcast processing

Options
    • -1
    • +1
    ./modules/balancing_chamber.py
    • -2
    • +6
    ./modules/valves.py
  3. … 1 more file in changeset.
1:30 pm

Vendor - TEL - Sameer Poyil

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

11:50 am

Vendor - TEL - Sameer Poyil

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-dialin into LDT-2004-dry-bicart---dd

Options
    • -61
    • +61
    ./dialysate_delivery.py
    • -113
    • +55
    ./modules/balancing_chamber.py
    • -167
    • +124
    ./modules/valves.py
  4. … 3 more files in changeset.
9:09 am

Zoltan Miskolci

Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

Monday 02 Feb
4:50 pm

Dara Navaei

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

4:43 pm

Dara Navaei

Treatment Params have been removed from firmware.

Treatment Params have been removed from firmware.