ro-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 2
Total Committers: 5
Last Commit: 18 Dec
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Aug
1:07 pm

Michael Garthwaite

LDT-566: fixed RO Pump publishing to no longer have debug data for PI control

Options
    • -5
    • +5
    ./ROPump.c
11:11 am

Michael Garthwaite

LDT-2003: 1st stage of flow control. still wip. moved event from bad crc error to all faults.

Options
    • -18
    • +35
    ./ROPump.c
  2. … 2 more files in changeset.
Wednesday 13 Aug
3:00 pm

Raghu Kallala

Removed commented code lines

Options
    • -2
    • +0
    ./ROPump.c
1:46 pm

Raghu Kallala

Addressed review comments and modified the override behavior as discussed.

Options
    • -174
    • +161
    ./ROPump.c
    • -1
    • +1
    ./ROPump.h
  3. … 1 more file in changeset.
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -20
    • +20
    ./Valves.c
    • -21
    • +5
    ./Valves.h
  3. … 1 more file in changeset.
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -20
    • +20
    ./Valves.c
    • -21
    • +5
    ./Valves.h
  3. … 1 more file in changeset.
Monday 11 Aug
10:15 am

Raghu Kallala

Addressed review comments to remove blank lines

Options
    • -6
    • +0
    ./ROPump.c
Friday 08 Aug
11:53 am

Raghu Kallala

Fix for RO Pump override set and reset.

Options
    • -75
    • +239
    ./ROPump.c
11:34 am

Raghu Kallala

Modified handlers to change state based on data value rather than using get functions.

Options
    • -11
    • +11
    ./ROPump.c
Thursday 07 Aug
2:22 pm

Raghu Kallala

Fixed the override reset behavior in test function

Options
    • -3
    • +12
    ./ROPump.c
12:10 pm

Michael Garthwaite

Merge branch 'staging' into feature/LDT-1809-iofp-ws-setup-and-bug-fixing

Options
    • -7
    • +4
    ./ROPump.c
12:08 pm

Raghu Kallala

Changes for RO pump override reset.

Options
    • -31
    • +10
    ./ROPump.c
8:46 am

Raghu Kallala

Updated code for multiple override.

Options
    • -61
    • +153
    ./ROPump.c
Tuesday 05 Aug
12:41 pm

Raghu Kallala

WIP for setting multiple overrides

Options
    • -5
    • +14
    ./ROPump.c
10:24 am

Raghu Kallala

removed check for zero flow rate

Options
    • -5
    • +0
    ./ROPump.c
10:22 am

Raghu Kallala

Added backup variable for pump data and fixed set function behavior

Options
    • -74
    • +154
    ./ROPump.c
Monday 04 Aug
9:26 am

Michael Garthwaite

LDT-566: code review comments.

Options
    • -2
    • +0
    ./PermeateTank.c
  2. … 2 more files in changeset.
Friday 01 Aug
3:56 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -8
    • +7
    ./PermeateTank.c
    • -3
    • +0
    ./ROPump.c
  3. … 12 more files in changeset.
12:08 pm

Michael Garthwaite

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

Options
    • -1
    • +3
    ./BoostPump.c
    • -4
    • +6
    ./ROPump.c
  3. … 6 more files in changeset.
Thursday 31 Jul
11:51 am

Michael Garthwaite

LDT-566: fixed macro calls

Options
    • -4
    • +4
    ./ROPump.c
11:49 am

Michael Garthwaite

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Options
    • -3
    • +3
    ./BoostPump.c
    • -1
    • +1
    ./PermeateTank.c
    • -7
    • +7
    ./ROPump.c
  4. … 3 more files in changeset.
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -11
    • +5
    ./BoostPump.c
    • -650
    • +0
    ./Heaters.c
    • -60
    • +0
    ./Heaters.h
    • -18
    • +20
    ./ROPump.c
    • -3
    • +0
    ./ROPump.h
  6. … 15 more files in changeset.
11:24 am

Michael Garthwaite

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

Options
    • -5
    • +350
    ./PermeateTank.c
    • -7
    • +10
    ./PermeateTank.h
  3. … 19 more files in changeset.
Tuesday 29 Jul
1:05 pm

Michael Garthwaite

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Options
    • -1
    • +1
    ./PermeateTank.c
  2. … 7 more files in changeset.
12:15 pm

Michael Garthwaite

LDT-566: FP Safety shutdown override. fixed includes.

Options
    • -0
    • +52
    ./PermeateTank.c
    • -0
    • +65
    ./PermeateTank.h
    • -3
    • +2
    ./ROPump.c
  4. … 10 more files in changeset.
9:58 am

Michael Garthwaite

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

Options
    • -1
    • +2
    ./BoostPump.c
    • -1
    • +1
    ./Heaters.c
    • -1
    • +2
    ./ROPump.c
  4. … 37 more files in changeset.
Friday 25 Jul
1:12 pm

Michael Garthwaite

LDT-566: fixed valve order

Options
    • -3
    • +3
    ./Valves.h
1:09 pm

Michael Garthwaite

LDT-566: fixed valve ordering

Options
    • -2
    • +2
    ./Valves.h
9:18 am

Michael Garthwaite

Revert "LDT-566: permeate tank file creation"

This reverts commit 6e65344e6675394118806ce98dc428c27920e1cb.

Options
    • -428
    • +0
    ./PermeateTank.c
    • -60
    • +0
    ./PermeateTank.h
9:16 am

Michael Garthwaite

LDT-566: permeate tank file creation

Options
    • -0
    • +428
    ./PermeateTank.c
    • -0
    • +60
    ./PermeateTank.h