ro-firmware

firmware

Clone Tools

Stats

Commits this week: 4
Total Committers: 6
Last Commit: 18 Dec
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 01 Aug
3:56 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -8
    • +7
    ./App/Controllers/PermeateTank.c
    • -3
    • +0
    ./App/Controllers/ROPump.c
    • -1
    • +0
    ./App/Modes/FPModeStandby.c
    • -2
    • +0
    ./App/Modes/FlushConcentrate.c
    • -1
    • +0
    ./App/Modes/ModePreGenPermeate.c
    • -1
    • +0
    ./App/Modes/ModePreGenPermeateDefeatured.h
    • -1
    • +0
    ./App/Monitors/Pressure.c
    • -4
    • +0
    ./App/Monitors/Temperature.c
    • -1
    • +0
    ./App/Services/AlarmMgmtFP.h
    • -6
    • +0
    ./App/Services/DDInterface.c
    • -1
    • +1
    ./App/Services/DDInterface.h
    • -1
    • +0
    ./App/Services/FpgaFP.c
    • -4
    • +3
    ./App/Services/Messaging.c
    • -1
    • +0
    ./App/Services/SystemCommFP.c
12:22 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -1
    • +1
    ./App/Drivers/ConductivitySensor.c
    • -2
    • +4
    ./App/Modes/ModeGenPermeateDefeatured.c
    • -7
    • +6
    ./App/Modes/ModeGenPermeateDefeatured.h
    • -4
    • +8
    ./App/Modes/ModePreGenPermeateDefeatured.c
    • -6
    • +6
    ./App/Modes/ModePreGenPermeateDefeatured.h
    • -2
    • +0
    ./source/sys_main.c
12:08 pm

Michael Garthwaite

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

Options
    • -1
    • +3
    ./App/Controllers/BoostPump.c
    • -4
    • +6
    ./App/Controllers/ROPump.c
    • -1
    • +1
    ./App/Drivers/ConductivitySensor.c
    • -3
    • +3
    ./App/Drivers/PressureSensor.c
    • -0
    • +1
    ./App/Modes/FlushConcentrate.c
    • -0
    • +0
    ./App/Modes/PressureCheck.c
    • -15
    • +0
    ./App/Modes/PressureCheck.h
    • -5
    • +0
    ./App/Monitors/WaterQualityMonitor.c
Thursday 31 Jul
11:51 am

Michael Garthwaite

LDT-566: fixed macro calls

Options
    • -4
    • +4
    ./App/Controllers/ROPump.c
11:49 am

Michael Garthwaite

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Options
    • -3
    • +3
    ./App/Controllers/BoostPump.c
    • -1
    • +1
    ./App/Controllers/PermeateTank.c
    • -7
    • +7
    ./App/Controllers/ROPump.c
    • -1
    • +1
    ./App/Drivers/FluidPump.h
    • -1
    • +1
    ./App/Modes/FlushPermeate.c
    • -4
    • +5
    ./source/sys_main.c
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -11
    • +5
    ./App/Controllers/BoostPump.c
    • -650
    • +0
    ./App/Controllers/Heaters.c
    • -60
    • +0
    ./App/Controllers/Heaters.h
    • -18
    • +20
    ./App/Controllers/ROPump.c
    • -3
    • +0
    ./App/Controllers/ROPump.h
    • -399
    • +0
    ./App/Drivers/TemperatureSensor.c
    • -59
    • +0
    ./App/Drivers/TemperatureSensor.h
    • -1
    • +1
    ./App/Modes/FPModeStandby.c
    • -19
    • +24
    ./App/Modes/FlushConcentrate.c
    • -2
    • +1
    ./App/Modes/FlushConcentrate.h
    • -10
    • +11
    ./App/Modes/FlushFilter.c
    • -9
    • +13
    ./App/Modes/FlushPermeate.c
    • -30
    • +13
    ./App/Modes/ModeGenPermeate.c
    • -9
    • +4
    ./App/Modes/ModeGenPermeate.h
    • -1
    • +0
    ./App/Monitors/Conductivity.c
  16. … 5 more files in changeset.
11:24 am

Michael Garthwaite

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

Options
    • -5
    • +350
    ./App/Controllers/PermeateTank.c
    • -7
    • +10
    ./App/Controllers/PermeateTank.h
    • -9
    • +7
    ./App/Modes/FPModeFault.c
    • -5
    • +6
    ./App/Modes/FlushConcentrate.c
    • -6
    • +5
    ./App/Modes/FlushFilter.c
    • -7
    • +8
    ./App/Modes/FlushPermeate.c
    • -123
    • +11
    ./App/Modes/ModeGenPermeate.c
    • -4
    • +4
    ./App/Modes/ModeGenPermeateDefeatured.c
    • -24
    • +25
    ./App/Modes/ModePreGenPermeate.c
    • -12
    • +12
    ./App/Modes/ModePreGenPermeateDefeatured.c
    • -1
    • +66
    ./App/Monitors/Temperature.c
    • -0
    • +20
    ./App/Monitors/Temperature.h
    • -76
    • +0
    ./App/Monitors/WaterQualityMonitor.c
    • -19
    • +0
    ./App/Monitors/WaterQualityMonitor.h
    • -18
    • +26
    ./App/Services/AlarmMgmtFP.c
  16. … 6 more files in changeset.
Tuesday 29 Jul
3:54 pm

Michael Garthwaite

LDT-566: fixed messaging ACK

Options
    • -4
    • +4
    ./App/Services/Messaging.c
1:05 pm

Michael Garthwaite

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Options
    • -1
    • +1
    ./App/Controllers/PermeateTank.c
    • -19
    • +245
    ./App/Modes/FPModeFault.c
    • -1
    • +1
    ./App/Modes/FPModeFault.h
    • -3
    • +0
    ./App/Modes/FlushConcentrate.c
    • -2
    • +0
    ./App/Modes/FlushFilter.c
    • -3
    • +0
    ./App/Modes/FlushPermeate.c
    • -5
    • +5
    ./App/Modes/ModeGenPermeate.c
    • -1
    • +1
    ./App/Services/AlarmMgmtFP.c
12:15 pm

Michael Garthwaite

LDT-566: FP Safety shutdown override. fixed includes.

Options
    • -0
    • +52
    ./App/Controllers/PermeateTank.c
    • -0
    • +65
    ./App/Controllers/PermeateTank.h
    • -3
    • +2
    ./App/Controllers/ROPump.c
    • -2
    • +2
    ./App/Drivers/PAL.c
    • -1
    • +1
    ./App/Drivers/PAL.h
    • -39
    • +22
    ./App/Drivers/SafetyShutdown.c
    • -2
    • +1
    ./App/Drivers/SafetyShutdown.h
    • -0
    • +1
    ./App/Modes/FPModeFault.c
    • -3
    • +6
    ./App/Modes/FPModeFault.h
    • -2
    • +2
    ./App/Modes/FPModeInitPOST.h
    • -2
    • +2
    ./App/Modes/FPModeStandby.h
    • -2
    • +2
    ./App/Modes/FPOperationModes.h
    • -1
    • +3
    ./App/Services/Messaging.c
10:06 am

Michael Garthwaite

WIP on develop

LDT-566: develop fixes

Options
    • -1
    • +1
    ./App/Modes/FlushConcentrate.c
    • -1
    • +1
    ./App/Modes/FlushFilter.c
    • -1
    • +1
    ./App/Modes/FlushPermeate.c
    • -1
    • +1
    ./App/Modes/ModeGenPermeateDefeatured.c
    • -5
    • +5
    ./App/Modes/ModePreGenPermeate.c
    • -3
    • +3
    ./App/Modes/ModePreGenPermeateDefeatured.c
9:58 am

Michael Garthwaite

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

Options
    • -1
    • +2
    ./App/Controllers/BoostPump.c
    • -1
    • +1
    ./App/Controllers/Heaters.c
    • -1
    • +2
    ./App/Controllers/ROPump.c
    • -1
    • +1
    ./App/Drivers/ConductivitySensor.c
    • -12
    • +11
    ./App/Drivers/PressureSensor.c
    • -1
    • +1
    ./App/Drivers/TemperatureSensor.c
    • -0
    • +88
    ./App/Modes/FPModeFault.c
    • -0
    • +40
    ./App/Modes/FPModeFault.h
    • -0
    • +66
    ./App/Modes/FPModeInitPOST.c
    • -0
    • +44
    ./App/Modes/FPModeInitPOST.h
    • -0
    • +149
    ./App/Modes/FPModeStandby.c
    • -0
    • +47
    ./App/Modes/FPModeStandby.h
    • -0
    • +475
    ./App/Modes/FPOperationModes.c
    • -0
    • +62
    ./App/Modes/FPOperationModes.h
    • -1
    • +2
    ./App/Modes/FlushConcentrate.c
  16. … 25 more files in changeset.
Friday 25 Jul
1:12 pm

Michael Garthwaite

LDT-566: fixed valve order

Options
    • -3
    • +3
    ./App/Controllers/Valves.h
1:09 pm

Michael Garthwaite

LDT-566: fixed valve ordering

Options
    • -2
    • +2
    ./App/Controllers/Valves.h
9:18 am

Michael Garthwaite

Revert "LDT-566: permeate tank file creation"

This reverts commit 6e65344e6675394118806ce98dc428c27920e1cb.

Options
    • -428
    • +0
    ./App/Controllers/PermeateTank.c
    • -60
    • +0
    ./App/Controllers/PermeateTank.h
9:16 am

Michael Garthwaite

LDT-566: permeate tank file creation

Options
    • -0
    • +428
    ./App/Controllers/PermeateTank.c
    • -0
    • +60
    ./App/Controllers/PermeateTank.h
8:28 am

Michael Garthwaite

LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

Options
    • -1
    • +2
    ./App/Controllers/Valves.c
    • -1
    • +4
    ./App/Controllers/Valves.h
    • -0
    • +6
    ./App/Modes/FlushConcentrate.c
    • -0
    • +6
    ./App/Modes/FlushFilter.c
    • -0
    • +6
    ./App/Modes/FlushPermeate.c
    • -1
    • +1
    ./App/Modes/ModeFault.c
    • -0
    • +7
    ./App/Modes/ModeGenPermeate.c
    • -0
    • +6
    ./App/Modes/ModeGenPermeateDefeatured.c
    • -0
    • +3
    ./App/Modes/ModePreGenPermeate.c
    • -0
    • +9
    ./App/Modes/ModePreGenPermeateDefeatured.c
    • -0
    • +3
    ./App/Modes/ModeStandby.c
    • -25
    • +125
    ./App/Monitors/Conductivity.c
    • -0
    • +1
    ./App/Monitors/Conductivity.h
    • -167
    • +2
    ./App/Monitors/Pressure.c
    • -308
    • +2
    ./App/Monitors/Temperature.c
  16. … 6 more files in changeset.
Tuesday 22 Jul
2:51 pm

Michael Garthwaite

WIP on develop

LDT-566: LDT-676: Removed M7 and P20 valves.

Options
    • -2
    • +0
    ./App/Controllers/Valves.h
    • -2
    • +0
    ./App/Modes/ModeFault.c
    • -2
    • +0
    ./App/Modes/ModeGenPermeate.c
    • -2
    • +0
    ./App/Modes/ModeStandby.c
2:08 pm

Michael Garthwaite

LDT-566: fixes for removing P22 and P23. fix warnings

Options
    • -24
    • +24
    ./App/Controllers/Heaters.c
    • -35
    • +2
    ./App/Drivers/TemperatureSensor.c
    • -30
    • +6
    ./App/Monitors/Temperature.c
    • -0
    • +1
    ./App/Services/FpgaFP.h
    • -0
    • +1
    ./App/Services/Messaging.c
    • -2
    • +4
    ./source/sys_main.c
1:47 pm

Michael Garthwaite

LDT-566: Changed temperature handling back to their respective drivers. Kept combined published temperature value.

Options
    • -10
    • +0
    ./App/Monitors/Pressure.c
    • -9
    • +9
    ./App/Monitors/Temperature.c
12:40 pm

Michael Garthwaite

LDT-566: merge pressure temperatures and conductivity temperature sensors into the temperature sensor broadcast

Options
    • -5
    • +3
    ./App/Drivers/TemperatureSensor.h
    • -9
    • +0
    ./App/Monitors/Pressure.h
    • -5
    • +12
    ./App/Monitors/Temperature.c
    • -3
    • +9
    ./App/Monitors/Temperature.h
    • -2
    • +2
    ./App/Services/FpgaFP.c
12:09 pm

Michael Garthwaite

LDT-566: Project renaming. Created version request handler. Updated mix max for fluid pumps

Options
    • -1
    • +1
    ./.project
    • -1
    • +1
    ./App/Drivers/FluidPump.h
    • -2
    • +2
    ./App/FPCommon.h
    • -27
    • +33
    ./App/Services/Messaging.c
    • -0
    • +1
    ./App/Services/Messaging.h
Thursday 17 Jul
3:47 pm

Michael Garthwaite

LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

Options
    • -2
    • +2
    ./App/Controllers/BoostPump.c
    • -1
    • +3
    ./App/Controllers/BoostPump.h
    • -2
    • +2
    ./App/Controllers/ROPump.c
    • -3
    • +5
    ./App/Controllers/ROPump.h
    • -1
    • +1
    ./App/Drivers/FluidPump.c
    • -3
    • +3
    ./App/Drivers/FluidPump.h
    • -3
    • +0
    ./App/Drivers/PressureSensor.c
    • -1
    • +0
    ./App/Drivers/PressureSensor.h
    • -17
    • +12
    ./App/Modes/ModeGenPermeate.c
    • -2
    • +0
    ./App/Monitors/Pressure.c
    • -3
    • +1
    ./App/Monitors/Pressure.h
    • -1
    • +1
    ./App/Services/AlarmMgmtFP.c
    • -0
    • +2
    ./source/sys_main.c
Tuesday 15 Jul
4:31 pm

Michael Garthwaite

LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate, set to med.

Options
    • -3
    • +22
    ./App/Controllers/BoostPump.c
    • -0
    • +1
    ./App/Controllers/BoostPump.h
    • -0
    • +19
    ./App/Controllers/ROPump.c
    • -0
    • +1
    ./App/Controllers/ROPump.h
    • -0
    • +5
    ./App/Modes/ModeFault.c
    • -4
    • +10
    ./App/Modes/ModeGenPermeate.c
    • -2
    • +2
    ./App/Modes/ModePreGenPermeate.c
    • -0
    • +2
    ./App/Services/Messaging.c
3:54 pm

Michael Garthwaite

LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed pre-gen transitioning. removed some checks for when gen water request it received.

Options
    • -45
    • +84
    ./App/Controllers/BoostPump.c
    • -0
    • +1
    ./App/Controllers/BoostPump.h
    • -59
    • +88
    ./App/Controllers/ROPump.c
    • -0
    • +11
    ./App/Controllers/ROPump.h
    • -15
    • +25
    ./App/FPCommon.h
    • -2
    • +21
    ./App/Modes/ModeFault.c
    • -12
    • +23
    ./App/Modes/ModeGenPermeate.c
    • -1
    • +2
    ./App/Modes/ModePreGenPermeate.c
    • -2
    • +2
    ./App/Modes/ModePreGenPermeateDefeatured.c
    • -0
    • +21
    ./App/Modes/ModeStandby.c
    • -1
    • +1
    ./App/Modes/OperationModes.c
    • -1
    • +1
    ./App/Services/AlarmMgmtFP.c
    • -21
    • +8
    ./App/Services/DDInterface.c
    • -5
    • +50
    ./App/Services/Messaging.c
Wednesday 09 Jul
2:23 pm

Michael Garthwaite

LDT-566: fixed compiiler err

Options
    • -2
    • +2
    ./App/Modes/FlushFilter.c
2:23 pm

Michael Garthwaite

LDT-566: updated flush exec functions to only call the transition function in one location.

Options
    • -5
    • +7
    ./App/Modes/FlushConcentrate.c
    • -6
    • +7
    ./App/Modes/FlushFilter.c
    • -4
    • +6
    ./App/Modes/FlushPermeate.c
2:14 pm

Michael Garthwaite

LDT-566: generate water modes both defeatured and ro featured

Options
    • -4
    • +31
    ./App/Controllers/BoostPump.c
    • -1
    • +5
    ./App/Controllers/BoostPump.h
    • -2
    • +28
    ./App/Controllers/ROPump.c
    • -1
    • +5
    ./App/Controllers/ROPump.h
    • -1
    • +15
    ./App/Drivers/FluidPump.c
    • -0
    • +1
    ./App/Drivers/FluidPump.h
    • -39
    • +0
    ./App/Drivers/TemperatureSensor.c
    • -1
    • +1
    ./App/Drivers/TemperatureSensor.h
    • -0
    • +395
    ./App/Modes/FlushConcentrate.c
    • -7
    • +48
    ./App/Modes/FlushConcentrate.h
    • -0
    • +6
    ./App/Modes/FlushFilter.c
    • -5
    • +17
    ./App/Modes/FlushPermeate.c
    • -21
    • +121
    ./App/Modes/ModeGenPermeate.c
    • -0
    • +4
    ./App/Modes/ModeGenPermeate.h
    • -5
    • +299
    ./App/Modes/ModeGenPermeateDefeatured.c
  16. … 14 more files in changeset.
Thursday 03 Jul
9:52 am

Michael Garthwaite

LDT-566: filtered conductivity implementation

Options
    • -14
    • +125
    ./App/Monitors/Conductivity.c
    • -0
    • +1
    ./App/Services/AlarmMgmtSWFaults.h
Wednesday 02 Jul
12:04 pm

Michael Garthwaite

LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

Options
    • -30
    • +34
    ./App/Controllers/BoostPump.c
    • -1
    • +1
    ./App/Controllers/BoostPump.h
    • -3
    • +3
    ./App/Controllers/Heaters.c
    • -6
    • +6
    ./App/Controllers/ROPump.c
    • -2
    • +2
    ./App/Controllers/Valves.c
    • -1
    • +1
    ./App/Drivers/ConductivitySensor.c
    • -2
    • +2
    ./App/Drivers/FlowSensor.c
    • -1
    • +1
    ./App/Drivers/FluidPump.c
    • -2
    • +2
    ./App/Drivers/PressureSensor.c
    • -1
    • +1
    ./App/Drivers/TemperatureSensor.c
    • -139
    • +0
    ./App/Modes/FilterFlush.c
    • -51
    • +0
    ./App/Modes/FilterFlush.h
    • -0
    • +0
    ./App/Modes/FlushConcentrate.c
    • -0
    • +15
    ./App/Modes/FlushConcentrate.h
    • -0
    • +365
    ./App/Modes/FlushFilter.c
  16. … 56 more files in changeset.