Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

I have to make sure the valve is correct before using it.

I have to make sure the valve is correct before using it.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

Declarations should be at top of scope.

Declarations should be at top of scope.

Is this temporary?

Is this temporary?

Done

Done

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Done

Done

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 94 more files in changeset.
move static function after public function

move static function after public function

let public function on top

let public function on top

Let all public functions come on top for all files

Let all public functions come on top for all files

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 3 more files in changeset.
Merge branch 'LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor' into develop

  1. … 3 more files in changeset.
Should we comment this out before merging?

Should we comment this out before merging?

LDT-1886 updated the ejector and valves modules after testing

  1. … 2 more files in changeset.
Done

Done

Done

Done

Align =

Align =

Should be 2 blank lines above/below test banner.

Should be 2 blank lines above/below test banner.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 95 more files in changeset.
Done

Done

Should we initialize to inactive (and use #define)?

Should we initialize to inactive (and use #define)?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 90 more files in changeset.
LDT-1886 added more comments

Took note that the FPGA interface is at the driver level.

Took note that the FPGA interface is at the driver level.

Done

Done