td-firmware / firmware / App / Controllers

Valves.c

Clone Tools

Stats

Commits this week: 6
Total Committers: 3
Last Commit: 09:44
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
37 mins ago

Sean Nash and Vendor - TEL - Sameer Poyil

Thursday 18 Dec
3:08 pm

Dara Navaei

We tend to initialize the local variables as a standard practice.

We tend to initialize the local variables as a standard practice.

3:01 pm

Dara Navaei

LDT-1886 updated the valves code to be able to rehome the valves if needed

Options
    • -2
    • +4
    ./Valves.c
  2. … 1 more file in changeset.
2:54 pm

Sean Nash

These don't need to be initialized to zero.

These don't need to be initialized to zero.

Wednesday 17 Dec
1:50 pm

Dara Navaei

LDT-1886 fixed the valves round down the encoder to division of 8 all the time

Options
    • -8
    • +2
    ./Valves.c
11:11 am

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -25
    • +25
    ./Valves.c
  2. … 2 more files in changeset.
11:07 am

Dara Navaei

Done

Done

11:06 am

Dara Navaei

Done

Done

11:05 am

Dara Navaei

Done

Done

11:04 am

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -37
    • +22
    ./Valves.c
10:49 am

Dara Navaei

Done

Done

10:48 am

Dara Navaei

Done

Done

Tuesday 16 Dec
2:55 pm

Dara Navaei

Done.

Done.

2:53 pm

Dara Navaei

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

2:17 pm

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2:15 pm

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2:13 pm

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

2:13 pm

Sean Nash

Is this temporary?

Is this temporary?

1:47 pm

Dara Navaei

LDT-1886 updated the valves homing sequence

Options
    • -70
    • +159
    ./Valves.c
  2. … 5 more files in changeset.
1:01 pm

Dara Navaei

Done

Done

Monday 15 Dec
2:23 pm

Sean Nash

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Sunday 14 Dec
7:26 pm

Dara Navaei

Done

Done

Friday 12 Dec
2:20 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -5
    • +5
    ./Valves.c
  2. … 94 more files in changeset.
Thursday 11 Dec
10:15 am

Vendor - TEL - Sameer Poyil

move static function after public function

move static function after public function

10:14 am

Vendor - TEL - Sameer Poyil

let public function on top

let public function on top

10:11 am

Vendor - TEL - Sameer Poyil

Let all public functions come on top for all files

Let all public functions come on top for all files

Tuesday 09 Dec
9:48 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Valves.c
  2. … 3 more files in changeset.
9:45 am

Dara Navaei

Merge branch 'LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor' into develop

Options
    • -11
    • +3
    ./Valves.c
  2. … 3 more files in changeset.
Friday 05 Dec
2:55 pm

Sean Nash

Should we comment this out before merging?

Should we comment this out before merging?

2:10 pm

Dara Navaei

LDT-1886 updated the ejector and valves modules after testing

Options
    • -11
    • +3
    ./Valves.c
  2. … 2 more files in changeset.