td-firmware / firmware / App / Drivers

RotaryValve.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 2
Last Commit: 13:50
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
8 hrs ago

Vendor - TEL - Sameer Poyil

11 hrs ago

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -30
    • +30
    ./RotaryValve.c
  2. … 2 more files in changeset.
11 hrs ago

Dara Navaei

Done

Done

11 hrs ago

Dara Navaei

Done

Done

11 hrs ago

Dara Navaei

Done

Done

11 hrs ago

Dara Navaei

Done

Done

11 hrs ago

Dara Navaei

Done

Done

Tuesday 16 Dec
2:55 pm

Dara Navaei

Done.

Done.

2:53 pm

Dara Navaei

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

2:17 pm

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2:15 pm

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2:13 pm

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

2:13 pm

Sean Nash

Is this temporary?

Is this temporary?

1:47 pm

Dara Navaei

LDT-1886 updated the valves homing sequence

Options
    • -0
    • +1
    ./RotaryValve.c
  2. … 5 more files in changeset.
1:01 pm

Dara Navaei

Done

Done

Monday 15 Dec
2:23 pm

Sean Nash

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Sunday 14 Dec
7:26 pm

Dara Navaei

Done

Done

Friday 12 Dec
2:20 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -5
    • +5
    ./RotaryValve.c
  2. … 94 more files in changeset.
Thursday 11 Dec
10:15 am

Vendor - TEL - Sameer Poyil

move static function after public function

move static function after public function

10:14 am

Vendor - TEL - Sameer Poyil

let public function on top

let public function on top

10:11 am

Vendor - TEL - Sameer Poyil

Let all public functions come on top for all files

Let all public functions come on top for all files

Friday 05 Dec
2:55 pm

Sean Nash

Should we comment this out before merging?

Should we comment this out before merging?

2:11 pm

Sean Nash

Wednesday 03 Dec
10:15 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./RotaryValve.c
  2. … 7 more files in changeset.
10:13 am

Dara Navaei

Merge branch 'LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor' into develop

Options
    • -0
    • +81
    ./RotaryValve.c
  2. … 7 more files in changeset.
10:12 am

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -0
    • +1
    ./RotaryValve.c
  2. … 3 more files in changeset.
Tuesday 02 Dec
9:50 am

Dara Navaei

Done

Done

9:49 am

Dara Navaei

Done

Done

9:16 am

Sean Nash

Align =

Align =

9:14 am

Sean Nash

Should be 2 blank lines above/below test banner.

Should be 2 blank lines above/below test banner.