application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 18 Apr 22
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Apr 2022
5:46 pm

Behrouz NematiPour

DEN-12597 Code Review

http://dvm-linux02:8060/cru/UI-DEN-12258-1#c12773

Disabled the coco end as well, which caused the coco to log a lot of warnings.

Options
    • -12
    • +12
    /sources/ApplicationController.cpp
    • -2
    • +2
    /sources/MainTimer.cpp
    • -2
    • +2
    /sources/Threads.cpp
    • -2
    • +2
    /sources/bluetooth/BluetoothInterface.cpp
    • -16
    • +16
    /sources/canbus/CanInterface.cpp
    • -8
    • +8
    /sources/canbus/FrameInterface.cpp
    • -2
    • +2
    /sources/canbus/MessageAcknowModel.cpp
    • -2
    • +2
    /sources/canbus/MessageBuilder.cpp
    • -9
    • +9
    /sources/canbus/MessageDispatcher.cpp
    • -2
    • +2
    /sources/canbus/MessageGlobals.h
    • -4
    • +4
    /sources/canbus/MessageInterpreter.cpp
    • -2
    • +2
    /sources/cloudsync/CloudSyncController.cpp
    • -12
    • +12
    /sources/device/DeviceController.cpp
    • -12
    • +12
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/GuiGlobals.cpp
  16. … 66 more files in changeset.
Tuesday 12 Apr 2022
6:50 pm

Behrouz NematiPour

DEN-12517 Code Analysis

Options
    • -6
    • +6
    /cppcheck.err
    • -199
    • +249
    /cppcheck.log
Monday 11 Apr 2022
7:37 pm

Behrouz NematiPour

DEN-12515: KBM: Usual Meetings/Support/Development [ CS/UI Integration on device , Tx Log ]

- implemented the TxLog change request during the meeting.

- Also updated the state changes in the FW.

Options
    • -3
    • +3
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /en_US.udic
    • -4
    • +4
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -23
    • +29
    /sources/storage/TreatmentLog.cpp
    • -18
    • +20
    /sources/storage/TreatmentLog.h
    • -5
    • +1
    /sources/view/hd/data/pretreatment/VPreTreatmentStatesData.cpp
    • -6
    • +1
    /sources/view/hd/data/pretreatment/VPreTreatmentStatesData.h
Tuesday 05 Apr 2022
8:20 pm

Behrouz NematiPour

DEN-12515: KBM: TxLog implementation

- implemented the message 1007 for TxLog to be sent to the CS on HD TxLog received message.

Options
    • -1
    • +1
    /denali.pro.user
    • -6
    • +6
    /sources/cloudsync/CloudSyncController.cpp
    • -4
    • +1
    /sources/cloudsync/CloudSyncController.h
    • -2
    • +2
    /sources/storage/TreatmentLog.h
    • -3
    • +2
    /sources/view/settings/VDateTime.cpp
12:56 am

Behrouz NematiPour

DEN-12512: INT: Support/Meetings/Planning

DEN-09712 Date format between system date/time and BP/HP "Last Read" is not consistent

DEN-09929 Treatment Log shows "?C" instead of "°C"

PRS-35: Regarding Sean's point about the create treatment parameters, made the parameters dynamic by the Configurations/DataList.cfg in ui.config repository.

Options
    • -5
    • +5
    /denali.pro.user
    • -0
    • +4
    /sources/ApplicationController.cpp
    • -1
    • +1
    /sources/ApplicationPost.cpp
    • -2
    • +6
    /sources/gui/qml/components/GridSelection.qml
    • -1
    • +0
    /sources/gui/qml/main.qml
    • -5
    • +0
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -0
    • +31
    /sources/model/settings/MSettings.cpp
    • -0
    • +10
    /sources/model/settings/MSettings.h
    • -1
    • +0
    /sources/storage/Settings.cpp
    • -0
    • +1
    /sources/storage/Settings.h
    • -1
    • +1
    /sources/storage/TreatmentLog.h
    • -1
    • +1
    /sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp
    • -3
    • +0
    /sources/view/hd/adjustment/common/VCommonAdjustmentVitals.h
    • -1
    • +2
    /sources/view/settings/VDateTime.cpp
Saturday 02 Apr 2022
9:47 pm

Behrouz NematiPour

DEN-12514: LTS: Support/Development

========== DevTest

- Fixed the reported bugs from the LTTS team:

+ https://github.com/Diality/testsuites/issues/38: Rejection messages are not displayed for heparin under main-treatment screen 38

+ https://github.com/Diality/testsuites/issues/37: "Self Test Complete!" message is not displayed when "DRY_SELF_TESTS_COMPLETE_STATE" is simulated #37

+ https://github.com/Diality/testsuites/issues/36: Indicators are not displayed for 'Wet Self tests" when "HD_PRIME_WET_SELF_TESTS_STATE" is simulated #36

========== CloudSync

- Changed the order of the device registration request and the device info send, in the order above.

========== Internal

- removed the emoji and language globe buttons from the second keyboard layout.

Options
    • -13
    • +13
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /en_US.udic
    • -2
    • +2
    /sources/cloudsync/CloudSyncController.cpp
    • -3
    • +19
    /sources/gui/qml/pages/treatment/sections/TreatmentHeparin.qml
    • -8
    • +8
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_US/symbols.qml
    • -14
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -0
    • +3
    /sources/view/hd/data/pretreatment/VPreTreatmentStatesData.cpp
    • -0
    • +3
    /sources/view/hd/data/pretreatment/VPreTreatmentStatesData.h
    • -7
    • +9
    /sources/view/hd/data/treatment/VHDTreatmentStatesData.cpp
    • -0
    • +1
    /sources/view/hd/data/treatment/VHDTreatmentStatesData.h
Monday 28 Mar 2022
12:39 pm

Behrouz NematiPour

DEN-12424: INT

- Adding the new 3 params of the alarm trigger

- Adding Rejection

- prepare for the singletons quit which are not in order, the quit should be done manually to be in order.

Options
    • -2
    • +2
    /AlarmMapping.csv
    • -2
    • +2
    /alarmMapping.sh
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/ApplicationController.cpp
    • -2
    • +0
    /sources/ApplicationController.h
    • -2
    • +1
    /sources/bluetooth/BluetoothInterface.h
    • -2
    • +0
    /sources/canbus/CanInterface.h
    • -2
    • +0
    /sources/canbus/FrameInterface.h
    • -2
    • +0
    /sources/canbus/MessageAcknowModel.h
    • -2
    • +0
    /sources/canbus/MessageDispatcher.h
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -2
    • +2
    /sources/cloudsync/CloudSyncController.h
    • -1
    • +1
    /sources/device/DeviceController.h
    • -2
    • +0
    /sources/gui/GuiController.h
    • -15
    • +21
    /sources/model/MAbstractDynamic.cpp
  16. … 6 more files in changeset.
Wednesday 23 Mar 2022
11:04 pm

Behrouz NematiPour

DEN-12427: KBM: UI modifications to match the CS needs

- Fixing the device info and version response/report.

Options
    • -1
    • +1
    /denali.pro.user
    • -13
    • +15
    /sources/cloudsync/CloudSyncController.cpp
    • -2
    • +2
    /sources/cloudsync/CloudSyncController.h
    • -0
    • +1
    /sources/utility/types.h
6:33 pm

Behrouz NematiPour

DEN-12427: KBM: Usual Meetings/Support/Development

- The UI will only send the 1006 (latest device state update) if only the state changes.

- Duplicate state updates will not log as an error and will only be ignore.

- The UI will always response back to 2006 (device state request) from CS with 1006 (latest device state) even if the state is the same as the last updated/requested.

Options
    • -2
    • +2
    /AlarmMapping.csv
    • -2
    • +2
    /denali.pro.user
    • -8
    • +21
    /sources/cloudsync/CloudSyncController.cpp
    • -1
    • +4
    /sources/cloudsync/CloudSyncController.h
    • -3
    • +3
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -0
    • +16
    /sources/utility/format.cpp
    • -7
    • +7
    /sources/utility/format.h
    • -1
    • +1
    /sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp
Monday 21 Mar 2022
7:36 pm

Behrouz NematiPour

DEN-12426: LTS: Bug / CR / Develop Coco / Manual

- removed the "// coco begin validated" to disable the manually validated coverage.

Options
    • -1
    • +1
    /denali.pro.user
    • -11
    • +11
    /sources/ApplicationController.cpp
    • -2
    • +2
    /sources/MainTimer.cpp
    • -2
    • +2
    /sources/Threads.cpp
    • -2
    • +2
    /sources/bluetooth/BluetoothInterface.cpp
    • -16
    • +16
    /sources/canbus/CanInterface.cpp
    • -8
    • +8
    /sources/canbus/FrameInterface.cpp
    • -2
    • +2
    /sources/canbus/MessageAcknowModel.cpp
    • -2
    • +2
    /sources/canbus/MessageBuilder.cpp
    • -9
    • +9
    /sources/canbus/MessageDispatcher.cpp
    • -2
    • +2
    /sources/canbus/MessageGlobals.h
    • -4
    • +4
    /sources/canbus/MessageInterpreter.cpp
    • -2
    • +2
    /sources/cloudsync/CloudSyncController.cpp
    • -12
    • +12
    /sources/device/DeviceController.cpp
    • -12
    • +12
    /sources/gui/GuiController.cpp
  16. … 67 more files in changeset.
12:59 pm

Behrouz NematiPour

DEN-12334: Heparin Delivery Paused Text Does Not Appear

Options
    • -0
    • +2
    /sources/gui/qml/pages/treatment/sections/TreatmentHeparin.qml
10:20 am

Behrouz NematiPour

DEN-12438: The In-Treatment Dialysate Flow section value is not updated

During the change of the parent flow class to the Dialysate flow and Blood flow, one thing which has not been caught during the development and code review is that the length of the Dialysate flow has changed as well from 8 to 7.

It has been caught by LTTS during their regression testing.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
Friday 18 Mar 2022
7:19 pm

Behrouz NematiPour

DEN-12383: Heparin Volume Delivered Treatment Monitor Resolution Should Be 0.1 mL

Options
    • -2
    • +4
    /sources/gui/qml/pages/treatment/sections/TreatmentFluid.qml
    • -1
    • +2
    /sources/gui/qml/pages/treatment/sections/TreatmentHeparin.qml
12:06 pm

Behrouz NematiPour

Fixed the build issue.

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +2
    /sources/gui/qml/AlarmItem.qml
11:12 am

Behrouz NematiPour

DEN-11812 UI Keyboard displays text on the spacebar and has a wink emoji button

- added the keyboard layout and style to remove some buttons and remove the text on the spacebar.

- added DEBUG_DISABLE_MAXIMIZE, due to touch screen issue on some devices, the maximized alarm can't be minimized to see the screen underneath.

- While fixing some issues in the Dialin/Simulator, added the reject reason notification to the Treatment review screen and cleared the values on rejection.

- update the Dialysate Temperature max to the 37 from 38.

Options
    • -1
    • +2
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -0
    • +33
    /denali.qrc
    • -1
    • +3
    /main.cpp
    • -0
    • +3
    /sources/gui/GuiGlobals.cpp
    • -3
    • +10
    /sources/gui/qml/AlarmItem.qml
    • -0
    • +1
    /sources/gui/qml/pages/posttreatment/PostTreatmentReview.qml
    • -0
    • +113
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_GB/dialpad.qml
    • -0
    • +112
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_GB/digits.qml
    • -0
    • +96
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_GB/handwriting.qml
    • -0
    • +208
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_GB/main.qml
    • -0
    • +184
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_GB/numbers.qml
    • -0
    • +376
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_GB/symbols.qml
    • -0
    • +113
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_US/dialpad.qml
    • -0
    • +112
    /sources/gui/qml/plugins/virtualkeyboard/layouts/en_US/digits.qml
  16. … 26 more files in changeset.
Sunday 13 Mar 2022
3:15 pm

Behrouz NematiPour

DEN-12262: INT: Support and debugging

- updated/tested the alarmMapping with new changes.

- added the staging to the alamMapping.sh call to checkout always on staging as the mainsteam.

Options
    • -2
    • +2
    /denali.pro.user
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.cpp
Thursday 10 Mar 2022
7:41 pm

Behrouz NematiPour

DEN-12262: INT: Support and debugging

- Fixing the DG Valves/Temperature messages

- Fixing the CloudSync RegisterDeviceRequest

- Fixed/Cherry-Picked the Dialin-log conditions.

- Cleaned up the debug messages.

Options
    • -1
    • +7
    /alarmMapping.sh
    • -4
    • +4
    /denali.pro.user
    • -1
    • +0
    /sources/canbus/CanInterface.cpp
    • -7
    • +7
    /sources/canbus/FrameInterface.cpp
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -2
    • +2
    /sources/cloudsync/CloudSyncController.cpp
    • -18
    • +20
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -0
    • +4
    /sources/model/dg/data/MDGTemperaturesData.cpp
    • -23
    • +26
    /sources/model/dg/data/MDGTemperaturesData.h
    • -13
    • +14
    /sources/model/dg/data/MDGValvesStatesData.h
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -1
    • +1
    /sources/storage/FileHandler.cpp
    • -1
    • +1
    /sources/storage/Logger.cpp
    • -1
    • +1
    /sources/storage/Settings.cpp
    • -1
    • +1
    /sources/storage/TreatmentLog.cpp
  16. … 6 more files in changeset.
12:59 pm

Behrouz NematiPour

DEN-12262: INT: Log Dialin Messages

- Log Dialin messages as part of the unhandled messages.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /en_US.udic
    • -0
    • +1
    /sources/canbus/MessageGlobals.h
    • -21
    • +46
    /sources/canbus/MessageInterpreter.cpp
    • -6
    • +6
    /sources/model/dg/data/MDGAccelerometerData.h
    • -6
    • +6
    /sources/model/dg/data/post/MDGPostFinalResultData.h
    • -6
    • +6
    /sources/model/dg/data/post/MDGPostSingleResultData.h
    • -6
    • +6
    /sources/model/hd/data/MHDAccelerometerData.h
    • -4
    • +4
    /sources/model/hd/data/MHDSyringePumpData.h
    • -6
    • +6
    /sources/model/hd/data/post/MHDPostFinalResultData.h
    • -3
    • +3
    /sources/model/hd/data/post/MHDPostSingleResultData.h
    • -2
    • +1
    /sources/view/settings/VDateTime.cpp
12:57 pm

Behrouz NematiPour

DEN-12262: INT: FW Support (Reset Diagnostic Data)

- Reorganized the Diagnostics screen a little more.

Options
    • -1
    • +1
    /denali.pro.user
    • -3
    • +6
    /sources/gui/qml/components/DebugDataColumn.qml
    • -51
    • +57
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
12:56 pm

Behrouz NematiPour

DEN-12262: INT: FW Support (Reset Diagnostic Data)

Options
    • -6
    • +6
    /AlarmMapping.csv
    • -0
    • +2
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -0
    • +1
    /sources/gui/GuiGlobals.cpp
    • -1
    • +2
    /sources/gui/qml/components/DebugDataColumn.qml
    • -106
    • +120
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -5
    • +8
    /sources/gui/qml/main.qml
    • -0
    • +101
    /sources/view/VGeneralEvent.cpp
    • -0
    • +84
    /sources/view/VGeneralEvent.h
    • -0
    • +1
    /sources/view/VView.h
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.cpp
Wednesday 09 Mar 2022
4:54 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
4:53 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /main.cpp
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +1
    /scripts/wifi_save_dhcp_interface.sh
    • -1
    • +1
    /sources/Threads.cpp
    • -1
    • +1
    /sources/canbus/FrameInterface.cpp
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/cloudsync/CloudSyncController.cpp
    • -1
    • +1
    /sources/cloudsync/CloudSyncController.h
    • -1
    • +1
    /sources/device/DeviceController.cpp
    • -1
    • +1
    /sources/device/DeviceError.h
    • -1
    • +1
    /sources/device/DeviceModels.cpp
    • -1
    • +1
    /sources/device/DeviceModels.h
    • -2
    • +2
    /sources/gui/GuiGlobals.cpp
    • -1
    • +1
    /sources/gui/GuiGlobals.h
  16. … 63 more files in changeset.
4:49 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -10
    • +10
    /sources/model/hd/alarm/MAlarmMapping.cpp
4:47 pm

Behrouz NematiPour

Merge branch 'DEN-12121-sw_dev-sprint-65' into staging

Options
    • -0
    • +16
    /denali.pro
    • -3
    • +5
    /sources/canbus/MessageGlobals.h
    • -0
    • +4
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +4
    /sources/gui/GuiGlobals.h
    • -2
    • +9
    /sources/gui/qml/main.qml
    • -0
    • +20
    /sources/model/MModel.h
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
4:46 pm

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into staging

Options
    • -0
    • +2
    /denali.pro
    • -0
    • +5
    /sources/model/MModel.h
3:39 pm

Behrouz NematiPour

DEN-12262: INT: Code reviews wrap up & support

- Addressed all the code review comments in another branch in here to facilitate the code review process and make the code ready while the actual code owner were busy supporting system for demo.

- Added another condition to the Alarm top/right countdown to hide the timer when FW is not even in the Treatment mode by the HDOpMode.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /en_US.udic
    • -1
    • +1
    /sources/gui/qml/AlarmItem.qml
    • -78
    • +88
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -0
    • +6
    /sources/model/dg/data/MDGAccelerometerData.cpp
    • -0
    • +6
    /sources/model/dg/data/MDGAccelerometerData.h
    • -6
    • +6
    /sources/model/dg/data/MDGConductivityData.h
    • -0
    • +6
    /sources/model/hd/data/MHDAccelerometerData.cpp
    • -0
    • +6
    /sources/model/hd/data/MHDAccelerometerData.h
    • -9
    • +9
    /sources/model/hd/data/MHDAirBubbleData.h
    • -9
    • +9
    /sources/model/hd/data/MHDAirTrapData.h
    • -16
    • +16
    /sources/model/hd/data/MHDBloodLeakData.h
    • -6
    • +6
    /sources/model/hd/data/treatment/MTreatmentBloodPrimeData.h
    • -6
    • +6
    /sources/model/hd/data/treatment/MTreatmentHeparinData.h
    • -6
    • +6
    /sources/model/hd/data/treatment/MTreatmentRecirculateData.h
  16. … 18 more files in changeset.
Monday 07 Mar 2022
9:48 pm

Behrouz NematiPour

DEN-12262: INT: FW Support (Reset Diagnostic Data)

- Fixed HD version title.

Options
    • -19
    • +19
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
Friday 04 Mar 2022
12:15 am

Behrouz NematiPour

UI-DEN-12182: UI-DEN-12182-2

- During code review of my code, cleaned up the code.

Options
    • -1
    • +2
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +0
    /sources/cloudsync/CloudSyncController.h
    • -2
    • +0
    /sources/device/DeviceController.cpp
    • -2
    • +0
    /sources/device/DeviceModels.cpp
    • -2
    • +2
    /sources/device/DeviceModels.h
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -4
    • +4
    /sources/view/hd/adjustment/pretreatment/VPreTreatmentAdjustmentDisposablesConfirm.cpp
Thursday 03 Mar 2022
6:20 pm

Behrouz NematiPour

DEN-10153: Treatment Log Comments Investigations

- Fixed the Treatment Review overlapped items.

Options
    • -3
    • +3
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -9
    • +20
    /sources/gui/qml/pages/posttreatment/PostTreatmentReview.qml
    • -4
    • +4
    /sources/model/hd/alarm/MAlarmMapping.cpp
2:45 pm

Michael Garthwaite

DEN-12121: Adjustments to Dianogistic Dialog to fit new FW versions better. Moved Pressures to have a bit more room for 5 digit values.

Options
    • -4
    • +6
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml