imake.sh

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-SUNRISE
UI-DEN-SUNRISE
UI Staging Unreviewed Commits
UI Staging Unreviewed Commits
Ok, sounds good. RESOLVED

Ok, sounds good.

RESOLVED

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

RESOLVED

RESOLVED

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

UI-DEN-14733_UI BN S90
UI-DEN-14733_UI BN S90
UI-DEN-14517_UI BN S88
UI-DEN-14517_UI BN S88
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

removed spaces.

removed spaces.

to align arterial(8 characters) and venous(6 characters) vertically, and to make it easier to compare the variables, to avoid missing a parameter.

to align arterial(8 characters) and venous(6 characters) vertically, and to make it easier to compare the variables, to avoid missing a parameter.

Why is there 2 spaces between . and field name?

Why is there 2 spaces between . and field name?

DEN-13962: UI: Update pressure limits to match treatment params and UI screen

- Completely restructure the vTreatmentCreate class and removed all the constant ranges properties from that to the VTreatmentRanges.

- Now reading all the constant ranges values from the DataList.conf from the ui.config repository.

- Used the RANGESET property type for the ranges in the VTreatmentRanges class to have by default properties for min,max, res(olution),def(ault) properties.

- Added an ability to slider to hide the handler when needed (Pre-Treatment)

- Hide the Slider handler when slider switch is off

- Added various PROPERTYs, like IDBASED, RAGESET, VALUESET

- Modified the MPreTreatmentAdjustRequest, duration parameter to treatmentDuration for clarifying.

- Modified the Settings class to able to parse a comment on the Group line.

- Updated the ConfirmTreatmentTable to hold the required labels and added translate function for them. removed the call for get names for performance, since those never change.

- Made the SettingsData connection, standard in the VSettings class.

  1. … 17 more files in changeset.