dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 21 Jun 23
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Jun 2023
11:20 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15683 Correct alignmen

Options
    • -1
    • +1
    ./Controllers/ConcentratePumps.c
11:13 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15683 Updates per code review comments

Options
    • -9
    • +5
    ./Controllers/ConcentratePumps.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.h
Tuesday 20 Jun 2023
6:04 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15683 Correct proper alarming of concentrate pumps

Options
    • -20
    • +56
    ./Controllers/ConcentratePumps.c
    • -1
    • +3
    ./Controllers/ConcentratePumps.h
Thursday 15 Jun 2023
5:09 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
5:09 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/ConcentratePumps.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeFill.c
4:29 pm

Dara Navaei

DEN-15571 updated the code

Options
    • -2
    • +3
    ./Controllers/ConcentratePumps.c
4:24 pm

Dara Navaei

DEN-15571, DEN-15398 changed the fill mode full speed prime time from 8 seconds to 7 seconds

Options
    • -1
    • +1
    ./Modes/ModeFill.c
4:22 pm

Dara Navaei

DEN-15571 addressed the code review comments

Options
    • -14
    • +11
    ./Modes/ModeChemicalDisinfect.c
1:55 pm

Dara Navaei

DEN-15571 updated the chemical disinfect drain status function

Options
    • -1
    • +5
    ./Modes/ModeChemicalDisinfect.c
Wednesday 14 Jun 2023
3:50 pm

Dara Navaei

DEN-15443 added code to transition back to ramp state in concenrate pumps if the new requested target speed is greater than the threshold

Options
    • -2
    • +11
    ./Controllers/ConcentratePumps.c
3:24 pm

Dara Navaei

DEN-15571 made changes in the chemical disinfect mode to not trigger the max temeprature and conductivity out of range until the end of the chemical disinfect mode

Options
    • -18
    • +20
    ./Modes/ModeChemicalDisinfect.c
9:57 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
9:57 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/ConcentratePumps.c
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -2
    • +2
    ./Controllers/DrainPump.c
    • -1
    • +1
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/Pressures.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -2
    • +2
    ./Modes/ModeFault.c
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfectActiveCool.c
  16. … 11 more files in changeset.
9:09 am

Dara Navaei

Merge branch 'staging' into DEN-15367-hd_dg_test_configuration_setup

Options
    • -7
    • +21
    ./Controllers/DrainPump.c
Tuesday 13 Jun 2023
5:04 pm

Dara Navaei

DEN-14657 removed code to not check the error bit of a temperature sensor and let the temperature out of range alarm trigger the alarm

Options
    • -52
    • +3
    ./Controllers/TemperatureSensors.c
1:56 pm

Dara Navaei

DEN-15571 changed the chemical disinfect temperature timeout from 1 minute to 5 minutes

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
1:33 pm

Dara Navaei

DEN-15367 removed the payload from the message that informs HD that DG is ready to dispense more fluid in DG. DEN-15571 fixed the chemical disinfect state machine to transition to cancel water path once the target temperature was not reached within the specified time

Options
    • -6
    • +11
    ./Modes/ModeChemicalDisinfect.c
    • -5
    • +2
    ./Services/SystemCommMessages.c
12:42 pm

Dara Navaei

DEN-15367 addressed a code review comment

Options
    • -1
    • +1
    ./Controllers/ConcentratePumps.c
10:37 am

Dara Navaei

DEN-15367 addressed the code review comments

Options
    • -2
    • +2
    ./Controllers/ConcentratePumps.c
    • -4
    • +4
    ./Controllers/DrainPump.c
    • -3
    • +3
    ./Controllers/ROPump.c
    • -7
    • +11
    ./Modes/ModeFill.c
    • -3
    • +14
    ./Modes/ModeROPermeateSample.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -3
    • +3
    ./Services/SystemCommMessages.c
    • -1
    • +1
    ./Services/SystemCommMessages.h
Monday 12 Jun 2023
5:35 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/DrainPump.c
1:55 pm

Dara Navaei

DEN-15522 fixed the heat disinfect active cool fill timeout not triggering. DEN-14805 fixed chemical disinfect reservoir leak alarm

Options
    • -4
    • +13
    ./Modes/ModeChemicalDisinfect.c
    • -6
    • +1
    ./Modes/ModeHeatDisinfectActiveCool.c
Sunday 11 Jun 2023
8:28 pm

Dara Navaei

DEN-15367 changed the RO permeate sample cancel water path. DEN-14004 changed the request message from UI to 0x89. DEN-15509 changed the reservoir threshold from 1700 to 1850 mL. DEN-15192 changed the concentrate pump low speed threshold.

Options
    • -10
    • +14
    ./Controllers/ConcentratePumps.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -5
    • +10
    ./Modes/ModeROPermeateSample.c
    • -1
    • +1
    ./Services/SystemComm.c
2:24 pm

Dara Navaei

-DEN-15367 fixed the transition to cancel water path in RO permeate sample mode -DEN-14004 changed the request message ID to 0x89 from UI to send the DG service record -DEN-15192 changed the concentrate pumps low speed check threshold -DEN-15509 changed the reservoir full threshold from 1700 mL to 1850 mL.

Options
    • -2
    • +2
    ./Modes/ModeFill.c
    • -1
    • +5
    ./Services/SystemComm.c
    • -8
    • +43
    ./Services/SystemCommMessages.c
    • -1
    • +4
    ./Services/SystemCommMessages.h
2:24 pm

Dara Navaei

DEN-14004 added another message to receive and send DG service record upon request from HD. The format of the payload is different from the format that is sent to UI

Options
    • -2
    • +2
    ./Modes/ModeFill.c
    • -1
    • +5
    ./Services/SystemComm.c
    • -8
    • +43
    ./Services/SystemCommMessages.c
    • -1
    • +4
    ./Services/SystemCommMessages.h
Saturday 10 Jun 2023
6:04 pm

Dara Navaei

DEN-15367, DEN-15389, DEN-15511, DEN-15443 added code in the mode fill to check for the conductivity of the values in the produce state and have a timeout. Removed the acid check at the end of the mode fill

Options
    • -7
    • +7
    ./Controllers/ConcentratePumps.c
    • -237
    • +219
    ./Modes/ModeFill.c
Friday 09 Jun 2023
5:42 pm

Dara Navaei

DEN-15367, DEN-15404 worked on RO permeate sample mode

Options
    • -5
    • +5
    ./Controllers/ROPump.c
    • -7
    • +12
    ./Modes/ModeROPermeateSample.c
    • -1
    • +2
    ./Modes/ModeROPermeateSample.h
    • -1
    • +1
    ./Services/SystemCommMessages.c
9:00 am

Dara Navaei

DEN-15367, DEN-15404 work in progress. Updated the RO permeate sample mode code to be able to receive and send ready command to HD for further dispensing or canceling the run

Options
    • -1
    • +1
    ./Controllers/ConcentratePumps.c
    • -54
    • +44
    ./Modes/ModeROPermeateSample.c
    • -1
    • +0
    ./Services/AlarmMgmtSWFaults.h
    • -1
    • +1
    ./Services/SystemComm.c
    • -5
    • +28
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
Tuesday 06 Jun 2023
2:41 pm

Dara Navaei

DEN-15367 added test configuration to be able to run chemical disinfect without PAA acid

Options
    • -1
    • +2
    ./Modes/ModeChemicalDisinfect.c
Monday 05 Jun 2023
9:55 am

Dara Navaei

DEN-15367, DEN-15446 renamed the function that checks whether any of the inlet water conditions are active in a cleaning mode

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfectActiveCool.c
    • -3
    • +3
    ./Services/AlarmMgmt.c
    • -1
    • +1
    ./Services/AlarmMgmt.h