application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 10 Nov 20
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Nov 2020
9:28 am

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review comments

Options
    • -10
    • +0
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -0
    • +1
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
Friday 06 Nov 2020
2:35 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Fixed bicarbonate concentrate enum

Options
    • -3
    • +1
    /sources/view/VTreatmentCreate.h
    • -2
    • +2
    /unittests/tst_views.cpp
Wednesday 04 Nov 2020
11:02 am

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review requests.

Options
    • -2
    • +2
    /sources/gui/qml/components/Slider.qml
    • -3
    • +2
    /sources/storage/StorageGlobals.cpp
    • -2
    • +2
    /sources/storage/StorageGlobals.h
    • -1
    • +1
    /sources/view/VTreatmentCreate.h
10:32 am

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review requests.

Options
    • -1
    • +1
    /sources/canbus/MessageInterpreter.h
    • -1
    • +1
    /sources/gui/qml/components/Slider.qml
    • -1
    • +1
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -2
    • +2
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
    • -1
    • +1
    /sources/model/MEndTreatmentResponse.h
    • -20
    • +20
    /sources/model/MTreatmentParametersResp.h
    • -1
    • +25
    /sources/model/hd/data/MPrimingData.h
    • -46
    • +0
    /unittests/tst_canbus.cpp
    • -6
    • +0
    /unittests/tst_canbus.h
    • -0
    • +50
    /unittests/tst_models.cpp
    • -0
    • +7
    /unittests/tst_models.h
Tuesday 03 Nov 2020
6:09 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Added class documentation and messaging information.

Options
    • -0
    • +22
    /sources/model/MEndTreatmentResponse.h
    • -0
    • +23
    /sources/model/MStartTreatmentResponse.h
    • -1
    • +41
    /sources/model/MTreatmentParametersResp.h
    • -10
    • +91
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +7
    /sources/view/VPriming.h
    • -0
    • +5
    /sources/view/VTreatmentBegin.h
    • -2
    • +7
    /sources/view/VTreatmentCreate.h
    • -0
    • +8
    /sources/view/VTreatmentEnd.h
4:23 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Removed newline characters. Fixed orgnization in denali.pro

Options
    • -13
    • +13
    /denali.pro
    • -3
    • +3
    /denali.pro.user
    • -3
    • +0
    /sources/model/MEndTreatmentResponse.h
    • -2
    • +0
    /sources/model/MStartTreatmentResponse.h
    • -2
    • +0
    /sources/model/hd/data/MPrimingData.h
    • -4
    • +0
    /sources/view/hd/alarm/VAlarmStatus.h
2:39 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Created constants for treatment parameter default, min, max, and resolution values. Included PRS references.

Options
    • -20
    • +136
    /sources/view/VTreatmentCreate.h
Monday 02 Nov 2020
5:05 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Reverting adding a left and right touch margin

- While the addition of these margins makes it easier to hit the knob, it also adds a distance during drag between the click point and the displayed knob position. If still needed, there should be a better way of increasing the left and right touch margin.

Options
    • -2
    • +0
    /sources/gui/qml/components/RangeRect.qml
4:13 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Updated ConfirmTreatmentTableEntry's description

Options
    • -0
    • +1
    /sources/gui/qml/components/ConfirmTreatmentTableEntry.qml
4:01 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Moved ConfirmTreatmentTableEntry.qml to the right place.

Options
    • -66
    • +0
    /ConfirmTreatmentTableEntry.qml
    • -1
    • +1
    /denali.qrc
    • -0
    • +66
    /sources/gui/qml/components/ConfirmTreatmentTableEntry.qml
3:47 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review comments, misc. cleanup

Options
    • -2
    • +4
    /ConfirmTreatmentTableEntry.qml
    • -25
    • +0
    /ProgressLine.qml
    • -1
    • +0
    /denali.qrc
    • -4
    • +1
    /sources/gui/qml/components/ConfirmTreatmentSubTable.qml
    • -7
    • +47
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -2
    • +2
    /sources/view/VTreatmentBegin.h
12:17 pm

Peter Lucia <plucia@diality.com>

DEN-4598, DEN-4609, DEN-4607: Updated unit tests, removed unused Storage namespace from ApplicationController.cpp, removed saveNewTreatment function from ApplicationController.h

Options
    • -3
    • +3
    /denali.pro.user
    • -1
    • +0
    /sources/ApplicationController.cpp
    • -2
    • +0
    /sources/ApplicationController.h
    • -7
    • +8
    /sources/view/VTreatmentCreate.cpp
    • -31
    • +96
    /unittests/tst_views.cpp
Friday 30 Oct 2020
7:49 pm

Peter Lucia <plucia@diality.com>

DEN-4598, DEN-4609, DEN-4607: Added VTreatmentEnd.cpp/.h, Added end treatment button to settings page, misc. cleanup.

Options
    • -2
    • +4
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -19
    • +0
    /sources/VTreatmentBegin.cpp
    • -35
    • +0
    /sources/VTreatmentBegin.h
    • -0
    • +1
    /sources/canbus/MessageGlobals.h
    • -0
    • +1
    /sources/gui/GuiGlobals.cpp
    • -2
    • +2
    /sources/gui/GuiGlobals.h
    • -0
    • +2
    /sources/gui/qml/main.qml
    • -0
    • +17
    /sources/gui/qml/pages/SettingsHome.qml
    • -2
    • +2
    /sources/model/MEndTreatmentResponse.h
    • -0
    • +15
    /sources/view/VTreatmentBegin.cpp
    • -0
    • +37
    /sources/view/VTreatmentBegin.h
    • -0
    • +40
    /sources/view/VTreatmentEnd.cpp
    • -0
    • +40
    /sources/view/VTreatmentEnd.h
    • -0
    • +1
    /sources/view/VView.h
    • -20
    • +0
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -2
    • +0
    /sources/view/hd/alarm/VAlarmStatus.h
1:41 pm

Peter Lucia <plucia@diality.com>

DEN-4598, DEN-4609, DEN-4607, DEN-4605: Updated unit tests and code coverage. Made changes requested in code review.

Options
    • -2
    • +2
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +6
    /sources/VTreatmentBegin.h
    • -0
    • +2
    /sources/canbus/MessageInterpreter.h
    • -1
    • +1
    /sources/gui/GuiGlobals.h
    • -0
    • +1
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -0
    • +55
    /sources/storage/FileSaver.cpp
    • -0
    • +50
    /sources/storage/FileSaver.h
    • -55
    • +0
    /sources/storage/filesaver.cpp
    • -50
    • +0
    /sources/storage/filesaver.h
    • -0
    • +6
    /sources/view/VPriming.h
    • -0
    • +2
    /sources/view/VTreatmentCreate.cpp
    • -4
    • +4
    /sources/view/VTreatmentCreate.h
    • -0
    • +20
    /sources/view/hd/alarm/VAlarmStatus.cpp
  16. … 7 more files in changeset.
Tuesday 27 Oct 2020
11:18 am

Peter Lucia <plucia@diality.com>

DEN-4605: Updated unit tests

Options
    • -4
    • +0
    /sources/canbus/MessageInterpreter.h
    • -0
    • +2
    /sources/model/hd/data/MPrimingData.h
    • -26
    • +0
    /unittests/tst_messaging.cpp
    • -1
    • +0
    /unittests/tst_messaging.h
    • -1
    • +91
    /unittests/tst_models.cpp
    • -0
    • +5
    /unittests/tst_models.h
Monday 26 Oct 2020
1:56 pm

Peter Lucia <plucia@diality.com>

Merge branch 'DEN-4598-Confirm-Priming-Begin' of ssh://dvm-linux02:7999/ui/application into DEN-4598-Confirm-Priming-Begin

Options
Friday 23 Oct 2020
10:24 am

Peter Lucia <plucia@diality.com>

DEN-4601, DEN-4607, DEN-5169: Improve Create Treatment page usability, Support latest SquishQt Tests, - Widened Create Treatment Parameters - Removed get and set prefix from the treatment parameter macro

Options
    • -2
    • +3
    /sources/gui/qml/components/GridSelection.qml
    • -11
    • +11
    /sources/gui/qml/components/Slider.qml
    • -3
    • +3
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -11
    • +7
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
    • -0
    • +2
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +1
    /sources/gui/qml/globals/Colors.qml
    • -0
    • +5
    /sources/gui/qml/globals/Variables.qml
    • -1
    • +5
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -2
    • +2
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -0
    • +3
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -4
    • +4
    /sources/main.h
    • -7
    • +7
    /sources/view/VTreatmentCreate.cpp
    • -102
    • +102
    /unittests/tst_views.cpp
10:24 am

Peter Lucia <plucia@diality.com>

DEN-5169: Removed get and set prefix from the treatment parameter macro.

Options
    • -4
    • +4
    /sources/main.h
    • -3
    • +3
    /sources/view/VTreatmentCreate.cpp
10:15 am

Peter Lucia <plucia@diality.com>

DEN-5169: Continue refactoring

Options
    • -4
    • +4
    /sources/gui/qml/components/ConfirmTreatmentTable.qml
    • -4
    • +3
    /sources/view/VPriming.h
Thursday 22 Oct 2020
6:25 pm

Peter Lucia <plucia@diality.com>

DEN-5169: Cleanup and refactoring.

Options
    • -6
    • +24
    /denali.pro.user
    • -2
    • +2
    /sources/VTreatmentBegin.cpp
    • -3
    • +1
    /sources/VTreatmentBegin.h
    • -4
    • +4
    /sources/gui/qml/components/ConfirmTreatmentTable.qml
    • -9
    • +9
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -14
    • +14
    /sources/main.h
    • -4
    • +6
    /sources/view/VPriming.cpp
    • -1
    • +1
    /sources/view/VPriming.h
    • -28
    • +28
    /sources/view/VTreatmentCreate.cpp
    • -16
    • +16
    /sources/view/VTreatmentCreate.h
    • -9
    • +9
    /unittests/tst_views.cpp
Wednesday 21 Oct 2020
5:26 pm

Peter Lucia <plucia@diality.com>

Merge master into DEN-4598-Confirm-Priming-Begin

Options
    • -4
    • +1
    /denali.pro
    • -18
    • +0
    /denali.pro.user
    • -11
    • +5
    /sources/gui/GuiGlobals.h
    • -3
    • +3
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -2
    • +2
    /sources/model/MModel.h
    • -1
    • +1
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmStatusData.h
11:05 am

Peter Lucia <plucia@diality.com>

DEN-4601: Priming view improvements

- Replaced priming circle with check with check inside the existing circle

- Increased create treatment scrolling deceleration

- Updated create treatment variable names

Options
    • -5
    • +5
    /ConfirmTreatmentTableEntry.qml
    • -15
    • +10
    /sources/gui/qml/components/ConfirmTreatmentTable.qml
    • -2
    • +1
    /sources/gui/qml/components/PrimingTimer.qml
    • -0
    • +1
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -0
    • +1
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
    • -76
    • +75
    /sources/gui/qml/globals/Variables.qml
    • -0
    • +1
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -7
    • +9
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -12
    • +15
    /sources/view/VPriming.cpp
    • -10
    • +15
    /sources/view/VPriming.h
Tuesday 20 Oct 2020
3:25 pm

Dara Navaei

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /main.cpp
    • -2
    • +2
    /sources/gui/GuiGlobals.h
    • -1
    • +1
    /sources/gui/qml/components/ImageClock.qml
    • -1
    • +1
    /sources/gui/qml/components/ImageWave.qml
    • -1
    • +1
    /sources/gui/qml/components/MainMenu.qml
    • -1
    • +1
    /sources/gui/qml/components/ProgressBar.qml
    • -1
    • +1
    /sources/gui/qml/components/ProgressBarEx.qml
    • -1
    • +1
    /sources/gui/qml/components/ProgressRect.qml
    • -1
    • +1
    /sources/gui/qml/components/RangeBar.qml
    • -1
    • +1
    /sources/gui/qml/components/RangeMarker.qml
    • -1
    • +1
    /sources/gui/qml/components/TickMarks.qml
    • -1
    • +1
    /sources/gui/qml/components/UltrafiltrationButton.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/AutoHideInfo.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/PowerOff.qml
    • -1
    • +1
    /sources/gui/qml/pages/ManagerHome.qml
  16. … 86 more files in changeset.
2:55 pm

Behrouz NematiPour

Merge branch 'DEN-5283_SalineBolus-FWmodification'

Options
2:11 pm

Peter Lucia <plucia@diality.com>

DEN-4598: Clear errors on success

Emitting fwValdiationSuccess to QML from VTreatmentCreate so parameters that were previously showing as invalid will show as accepted.

Options
    • -0
    • +23
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -0
    • +3
    /sources/view/VTreatmentCreate.cpp
    • -0
    • +1
    /sources/view/VTreatmentCreate.h
Monday 19 Oct 2020
3:12 pm

Peter Lucia <plucia@diality.com>

DEN-4601, DEN-4606, Removed unneeded models unit test.

Options
    • -111
    • +0
    /unittests/tst_models.cpp
    • -2
    • +0
    /unittests/tst_models.h
12:20 pm

Peter Lucia <plucia@diality.com>

DEN-4601, DEN-4606: Added parameter to confirm message, updated tst_views, ensure value is set upon press and released in Slider.qml

Options
    • -5
    • +5
    /denali.pro.user
    • -1
    • +1
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +8
    /sources/gui/qml/components/Slider.qml
    • -1
    • +1
    /sources/gui/qml/globals/Variables.qml
    • -2
    • +5
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -5
    • +4
    /sources/main.h
    • -2
    • +6
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -2
    • +14
    /sources/view/VTreatmentCreate.cpp
    • -0
    • +1
    /sources/view/VTreatmentCreate.h
    • -34
    • +30
    /unittests/tst_views.cpp
    • -2
    • +1
    /unittests/tst_views.h
Sunday 18 Oct 2020
6:21 pm

Behrouz NematiPour

DEN-5341: Code Analysis

Options
    • -3
    • +9
    /cppcheck.err
    • -79
    • +101
    /cppcheck.log
Friday 16 Oct 2020
8:39 pm

Behrouz NematiPour

5284: Implementation

Story related fixes:

- Used FW enum for Saline Bolus in Common repo

- txPaused modified the way FW understands and transmits.

Extra fixes:

- Changed the Ultrafiltration ref/meas vol to 3 decimal.

- Application version wasn't correctly shown

- Added a #define for the mouse event spy since on target it's not usually happening and is not useful neither on target nor on desktop for now.

- Fixed the author typo

Options
    • -4
    • +1
    /denali.pro
    • -19
    • +1
    /denali.pro.user
    • -1
    • +2
    /main.cpp
    • -9
    • +3
    /sources/gui/GuiGlobals.h
    • -1
    • +1
    /sources/gui/qml/components/ImageClock.qml
    • -1
    • +1
    /sources/gui/qml/components/ImageWave.qml
    • -1
    • +1
    /sources/gui/qml/components/MainMenu.qml
    • -1
    • +1
    /sources/gui/qml/components/ProgressBar.qml
    • -1
    • +1
    /sources/gui/qml/components/ProgressBarEx.qml
    • -1
    • +1
    /sources/gui/qml/components/ProgressRect.qml
    • -1
    • +1
    /sources/gui/qml/components/RangeBar.qml
    • -1
    • +1
    /sources/gui/qml/components/RangeMarker.qml
    • -1
    • +1
    /sources/gui/qml/components/TickMarks.qml
    • -1
    • +1
    /sources/gui/qml/components/UltrafiltrationButton.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/AutoHideInfo.qml
  16. … 88 more files in changeset.
1:17 pm

Peter Lucia <plucia@diality.com>

DEN-4601, DEN-5330: Preventing vertical drag inside flickable while dragging slider left and right. Allow priming to continue until priming support is added to FW.

Options
    • -0
    • +1
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -4
    • +10
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
    • -53
    • +55
    /sources/gui/qml/globals/Variables.qml
    • -2
    • +8
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -18
    • +62
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -6
    • +1
    /sources/view/VPriming.cpp
    • -1
    • +1
    /sources/view/VPriming.h
    • -2
    • +2
    /sources/view/VTreatmentCreate.cpp
    • -9
    • +7
    /sources/view/VTreatmentCreate.h