application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Jan 21
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 Jan 2021
11:56 am

Peter Lucia <plucia@diality.com>

DEN-4867: Code Review 0 - Requested Modifications

- Removed startBLETimer and killBLETimer so we are not creating and deleting timers. Only one timer will be used

- Added toggleBLETimer

- Logging measurements when they are received instead of using qDebug

- Passing device addr and name to BLEScanner instead of just addr so only a QBluetoothDeviceInfo object is necessary, allowing removal of the macAddress QString

- Removed VBluetoothDeviceInfo static cast in VBluetooth::doSelectDevice

Options
    • -4
    • +4
    /denali.pro.user
    • -75
    • +57
    /sources/bluetooth/BLEScanner.cpp
    • -6
    • +2
    /sources/bluetooth/BLEScanner.h
    • -2
    • +2
    /sources/gui/qml/pages/SettingsBluetooth.qml
    • -11
    • +13
    /sources/view/VBluetooth.cpp
    • -2
    • +2
    /sources/view/VBluetooth.h
Friday 15 Jan 2021
10:41 am

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -0
    • +1
    /.gitignore
    • -0
    • +10
    /denali.pro
    • -5
    • +5
    /denali.pro.user
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +5
    /sources/storage/StorageGlobals.cpp
    • -10
    • +10
    /sources/view/VBluetooth.cpp
    • -1
    • +1
    /sources/view/VBluetooth.h
Thursday 14 Jan 2021
4:43 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Preventing create treatment class from thinking a new treatment profile was saved when the bledevices.conf file is updated.

Options
    • -4
    • +14
    /sources/view/VTreatmentCreate.cpp
    • -0
    • +2
    /sources/view/VTreatmentCreate.h
4:39 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -20
    • +60
    /sources/bluetooth/BLEScanner.cpp
    • -2
    • +9
    /sources/bluetooth/BLEScanner.h
Wednesday 13 Jan 2021
4:47 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -4
    • +4
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /scripts/run.sh
    • -4
    • +0
    /sources/gui/qml/components/ScreenItem.qml
    • -21
    • +8
    /sources/gui/qml/components/SettingsItem.qml
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
Wednesday 30 Dec 2020
3:49 pm

Peter Lucia <plucia@diality.com>

DEN-4866, DEN-4863, DEN-4862: Added class descriptions, fixed unit test, ran static code analysis

- Fixed tst_canbus issue likely introduced in f1e100d1368

Options
    • -18
    • +25
    /cppcheck.err
    • -94
    • +134
    /cppcheck.log
    • -0
    • +13
    /sources/bluetooth/BLEScanner.h
    • -0
    • +8
    /sources/view/VBluetooth.h
    • -0
    • +7
    /sources/view/VBluetoothDeviceInfo.h
    • -6
    • +1
    /unittests/tst_canbus.cpp
Tuesday 29 Dec 2020
4:36 pm

Peter Lucia <plucia@diality.com>

DEN-4863, DEN-4865: Code Coverage and Unit Tests

Options
    • -3
    • +3
    /denali.pro.user
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -0
    • +17
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +2
    /sources/storage/FileHandler.cpp
    • -1
    • +4
    /sources/storage/Logger.cpp
    • -1
    • +10
    /sources/view/VTreatmentBegin.cpp
    • -0
    • +2
    /sources/view/VTreatmentBegin.h
    • -1
    • +1
    /sources/view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationInit.h
    • -0
    • +107
    /unittests/tst_models.cpp
    • -0
    • +9
    /unittests/tst_models.h
Wednesday 23 Dec 2020
5:28 pm

Peter Lucia <plucia@diality.com>

DEN-4863, DEN-4865: Updated unit tests and code coverage for bluetooth

Options
    • -0
    • +3
    /sources/bluetooth/BLEScanner.cpp
    • -0
    • +2
    /sources/view/VAlert.h
    • -0
    • +2
    /sources/view/VBluetooth.cpp
    • -1
    • +3
    /sources/view/VBluetoothDeviceInfo.cpp
    • -0
    • +7
    /sources/view/VBluetoothDeviceInfo.h
    • -4
    • +11
    /sources/view/VVitals.cpp
    • -0
    • +2
    /sources/view/VVitals.h
    • -0
    • +28
    /unittests/tst_views.cpp
    • -0
    • +2
    /unittests/tst_views.h
3:30 pm

Peter Lucia <plucia@diality.com>

DEN-4865, DEN-5642: Checking BLE connection before sending UF volume, fixed unit test errors and added object names to support squishqt tests

Options
    • -4
    • +4
    /denali.pro.user
    • -1
    • +4
    /sources/gui/qml/dialogs/Alert.qml
    • -0
    • +4
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -0
    • +2
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -0
    • +4
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +7
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -7
    • +17
    /sources/view/VTreatmentBegin.cpp
    • -0
    • +2
    /sources/view/VTreatmentBegin.h
    • -15
    • +0
    /unittests/tst_messaging.cpp
    • -1
    • +0
    /unittests/tst_messaging.h
    • -8
    • +0
    /unittests/tst_models.cpp
    • -3
    • +0
    /unittests/tst_models.h
    • -1
    • +0
    /unittests/tst_views.cpp
Thursday 17 Dec 2020
1:19 pm

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign' into 2020_EOY_DEMO

Options
1:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- added a touch expanding area for the TouchArea so regardless of its visual size it can have expanded touchable area.

- the touch expanding for the mute button set to 25 so it can have a bigger touch area that its size which is little.

Options
    • -1
    • +1
    /sources/gui/qml/components/MuteButton.qml
    • -0
    • +1
    /sources/gui/qml/components/NotificationBar.qml
    • -1
    • +4
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
Tuesday 15 Dec 2020
10:12 pm

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign' into 2020_EOY_DEMO

Options
    • -11
    • +13
    /sources/canbus/MessageInterpreter.cpp
    • -6
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
9:45 pm

Behrouz NematiPour

DEN-5833: Implementation

- Added a MACRO for convenience of empty payload messages handling.

Options
    • -1
    • +9
    /sources/canbus/MessageInterpreter.cpp
9:12 pm

Behrouz NematiPour

DEN-5833: Implementation

- Fixed the bug that alarm ID zero which is the clear the alarm indication wasn't updating the properties, so caused to alarm_ID changed notification signal not to raise and GUI wasn't getting updated.

Options
    • -6
    • +6
    /sources/view/hd/alarm/VAlarmStatus.cpp
3:35 pm

Peter Lucia <plucia@diality.com>

DEN-5515, DEN-5516: Moved bluetooth setup before UI application start in run.sh, fixed start treatment messaging

Options
    • -2
    • +2
    /denali.pro.user
    • -3
    • +6
    /scripts/run.sh
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -5
    • +2
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
10:53 am

Peter Lucia <plucia@diality.com>

Merge DEN-4860_BLE into 2020_EOY_DEMO

Options
    • -1
    • +14
    /denali.pro
    • -11
    • +11
    /denali.pro.user
    • -7
    • +10
    /denali.qrc
    • -8
    • +7
    /sources/canbus/MessageDispatcher.cpp
    • -7
    • +7
    /sources/canbus/MessageGlobals.h
    • -7
    • +17
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +4
    /sources/gui/GuiGlobals.cpp
    • -7
    • +29
    /sources/gui/GuiGlobals.h
    • -0
    • +117
    /sources/gui/qml/components/pretreatment/ConfirmTreatmentTable.qml
    • -0
    • +117
    /sources/gui/qml/components/pretreatment/SliderCreateTreatment.qml
    • -0
    • +180
    /sources/gui/qml/components/pretreatment/TopMenuBarCreateTreatment.qml
    • -0
    • +2
    /sources/gui/qml/globals/Fonts.qml
    • -0
    • +6
    /sources/gui/qml/globals/Variables.qml
    • -24
    • +32
    /sources/gui/qml/main.qml
    • -1
    • +2
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
  16. … 10 more files in changeset.
10:17 am

Peter Lucia <plucia@diality.com>

Merge master into DEN-4860_BLE

Options
    • -0
    • +12
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -1
    • +7
    /denali.qrc
    • -19
    • +33
    /main.cpp
    • -1
    • +1
    /sources/bluetooth/BLEScanner.cpp
    • -0
    • +28
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +11
    /sources/canbus/MessageGlobals.h
    • -1
    • +15
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +3
    /sources/gui/GuiGlobals.cpp
    • -71
    • +85
    /sources/gui/GuiGlobals.h
    • -0
    • +1
    /sources/gui/qml/globals/Fonts.qml
    • -11
    • +48
    /sources/gui/qml/globals/Variables.qml
    • -1
    • +0
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +0
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -2
    • +0
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
  16. … 9 more files in changeset.
9:47 am

Peter Lucia <plucia@diality.com>

DEN-5515, DEN-5516: Disabled verbose bluetooth debugging

Options
    • -1
    • +1
    /sources/bluetooth/BLEScanner.cpp
    • -2
    • +2
    /sources/view/VVitals.cpp
9:44 am

Peter Lucia <plucia@diality.com>

DEN-5515, DEN-5516: Added bluetooth setup to run.sh

Options
    • -0
    • +5
    /scripts/run.sh
Monday 14 Dec 2020
7:03 pm

Behrouz NematiPour

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into 2020_EOY_DEMO

Options
7:02 pm

Behrouz NematiPour

DEN-5754: Implementation

- linked the pre-treatment ultrafiltration adjustment with the in-treatment ultrafiltration section and the adjustment flow.

- added the rejection reason text to the pTx uf adj screen.

Options
    • -1
    • +1
    /sources/gui/qml/components/NotificationBar.qml
    • -1
    • +1
    /sources/gui/qml/globals/Variables.qml
    • -10
    • +14
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -2
    • +17
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
2:55 pm

Peter Lucia <plucia@diality.com>

DEN-5515, DEN-5516: Setup in-treatment bp/hr measurement alerts

- Replaced some instances of qDebug with LOG_DEBUG

- Docstring fixes, cleanup

Options
    • -1
    • +5
    /sources/bluetooth/BLEScanner.cpp
    • -3
    • +9
    /sources/gui/GuiGlobals.h
    • -0
    • +2
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +2
    /sources/view/VAlert.cpp
    • -3
    • +4
    /sources/view/VAlert.h
    • -5
    • +10
    /sources/view/VTreatmentBegin.cpp
    • -5
    • +6
    /sources/view/VTreatmentCreate.cpp
    • -1
    • +110
    /sources/view/VVitals.cpp
    • -5
    • +20
    /sources/view/VVitals.h
1:44 pm

Behrouz NematiPour

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into 2020_EOY_DEMO

Options
    • -1
    • +1
    /sources/gui/GuiGlobals.h
1:43 pm

Behrouz NematiPour

DEN-5754: Implementation

- Fixed the message id of the ID_ConfirmTreatmentReq from 58 to 59

- Enabled the priming button for now since there is no FW implementation.

Options
    • -1
    • +1
    /sources/gui/GuiGlobals.h
    • -1
    • +2
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
1:39 pm

Behrouz NematiPour

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into 2020_EOY_DEMO

Options
    • -2
    • +6
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +13
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +1
    /sources/canbus/MessageDispatcher.h
    • -3
    • +8
    /sources/canbus/MessageGlobals.h
    • -4
    • +2
    /sources/canbus/MessageInterpreter.cpp
    • -15
    • +24
    /sources/gui/GuiGlobals.h
    • -0
    • +2
    /sources/gui/qml/main.qml
    • -3
    • +13
    /sources/model/MModel.h
    • -0
    • +28
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
12:33 pm

Behrouz NematiPour

DEN-5833: Implementation

- Moved version and sd-card icon to to not to cover others.

Options
    • -6
    • +5
    /sources/gui/qml/main.qml
11:57 am

Behrouz NematiPour

DEN-5754: Implementation

- Removed the unused flag of ALARM_ID_TEMPERATURE_SENSORS_INCONSISTENT

Options
    • -1
    • +0
    /sources/model/hd/alarm/MAlarmStatusData.cpp
9:16 am

Peter Lucia <plucia@diality.com>

DEN-5516, 5514 - BLE Interface updates

- When reconnecting to the last paired device on startup, ensure we repeatedly try to connect to it by updating the BLE connection type

- Docstring additions

- Keeping some code in case it is needed for future use with other BLE devices

Options
    • -3
    • +13
    /sources/bluetooth/BLEScanner.cpp
    • -2
    • +3
    /sources/view/VBluetooth.cpp
Sunday 13 Dec 2020
9:20 pm

Behrouz NematiPour

DEN-5754: Implementation

- Removed the semi-colon at the end of the imports.

Options
    • -24
    • +24
    /sources/gui/qml/main.qml
Friday 11 Dec 2020
6:06 pm

Behrouz NematiPour

DEN-5833: Implementation

- The message 63 has been tested

Options
    • -1
    • +1
    /denali.pro.user
    • -25
    • +26
    /sources/gui/qml/main.qml
    • -1
    • +15
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +1
    /sources/view/hd/alarm/VAlarmStatus.h