sources

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Server coverage issue fixed

- This line was not covered on server although it was covered on local.

Tested locally and it is working.

Build failed on server because the fw common branch master was changed.

- commented out the removed enum from application.

    • -4
    • +4
    ./view/hd/data/VHDTreatmentStatesData.cpp
DEN-5838: Code Review 0

  1. … 1 more file in changeset.
DEN-5836: Code Coverage

- 100.000% (4827/4827)

- added a unit test for the AlarmGenerator private method setBits.

  1. … 3 more files in changeset.
DEN-5836: Code Coverage

- 99.979% (4826/4827)

DEN-5836: Code Coverage

- commented as manually tested the AlarmClearedCondition.

    • -1
    • +1
    ./gui/qml/dialogs/NotificationDialog.qml
  1. … 1 more file in changeset.
DEN-5836: Alarm:Code Coverage

- 99.110% (4790/4833)

    • -1
    • +2
    ./model/hd/alarm/MAlarmClearedCondition.h
  1. … 1 more file in changeset.
DEN-5836: Alarm:Code Coverage

- updated the alarm message table

- fixed the -q parameter

    • -59
    • +111
    ./model/hd/alarm/MAlarmStatusData.cpp
  1. … 1 more file in changeset.
DEN-5833: Implementation

- Added a UI "AlarmGenerator" class to handle the HD_COMM_TIMEOUT and later the BLE Cuff alarm (PRS 395).

    • -0
    • +75
    ./AlarmGenerator.cpp
  1. … 1 more file in changeset.
DEN-5833: Implementation

- added a touch expanding area for the TouchArea so regardless of its visual size it can have expanded touchable area.

- the touch expanding for the mute button set to 25 so it can have a bigger touch area that its size which is little.

    • -0
    • +1
    ./gui/qml/components/NotificationBar.qml
    • -0
    • +1
    ./gui/qml/dialogs/NotificationDialog.qml
DEN-5833: Implementation

- Added a MACRO for convenience of empty payload messages handling.

DEN-5833: Implementation

- Fixed the bug that alarm ID zero which is the clear the alarm indication wasn't updating the properties, so caused to alarm_ID changed notification signal not to raise and GUI wasn't getting updated.

DEN-5833: Implementation

- Moved version and sd-card icon to to not to cover others.

DEN-5833: Implementation

- The message 63 has been tested

  1. … 1 more file in changeset.
DEN-5833: Implementation

- Added the message 63 (req/rsp)

    • -0
    • +41
    ./model/hd/alarm/MAlarmClearedCondition.cpp
    • -0
    • +79
    ./model/hd/alarm/MAlarmClearedCondition.h
  1. … 2 more files in changeset.
DEN-5833: Implementation

- moved version and SD-Card icon to top which were covering the alarm bar.

- added list icon on the notification bar

- implemented the basics of the alarm list dialog.

- tweaked the Notification default coloring

-

    • -4
    • +28
    ./gui/qml/components/NotificationBar.qml
    • -0
    • +100
    ./gui/qml/dialogs/AlarmListDialog.qml
    • -3
    • +3
    ./gui/qml/dialogs/NotificationDialog.qml
  1. … 6 more files in changeset.
DEN-5833: Implementation

- fix a naming bug.

DEN-5833: Implementation

- Fixed the bug of silence logic which was reverse

- Fixed the bug that length of the silence message payload was incorrectly set to 4 instead of 1.

- changed the name of the MAlarmSilenceReq member variable to silence instead of state which now implies it is silent (1) or not (0).

DEN-5833: Implementation

- made the mute button click optional and currently enabled.

- made minimize on silent on the Notification Dialog optional and is disabled currently.

- made separate slots for each user actions instead of one for all with 4 parameter cause I think it's easier and more convenient to use this way.

- increased the Notification Bar height a little bit more.

    • -2
    • +4
    ./gui/qml/components/NotificationBar.qml
    • -12
    • +45
    ./view/hd/alarm/VAlarmStatus.cpp
DEN-5833: Implementation

- Implementation of the message 64: 'Alarm User Action'

- Cleaned up the VAlarmStatus class.

    • -38
    • +35
    ./view/hd/alarm/VAlarmStatus.cpp
DEN-5833: Implementation

- Added User Action message response model.

  1. … 1 more file in changeset.
DEN-5833: Implementation

- Fixed a bouncing bug of the message when sent for the first time with silenced flag on to show the alarm not maximized.

    • -1
    • +12
    ./gui/qml/dialogs/NotificationDialog.qml
DEN-5833: Implementation

- Added 3 Alarm buttons

- created Mute Button

- created Up and Down Button (minimize/maximize)

- used FW alarm status flag enum (Alarm_State_Flag_Bit_Positions) instead of the UI version and removed UI one.

Code cleaned up

- modified and cleaned up Notification Dialog and Bar.

- modified Time Text component to be able to show sections with one zero only.

- cleaned up main.qml

    • -0
    • +60
    ./gui/qml/components/MuteButton.qml
    • -37
    • +27
    ./gui/qml/components/NotificationBar.qml
    • -0
    • +37
    ./gui/qml/components/UpDownButton.qml
    • -40
    • +87
    ./gui/qml/dialogs/NotificationDialog.qml
    • -18
    • +0
    ./model/hd/alarm/MAlarmStatusData.h
    • -22
    • +17
    ./view/hd/alarm/VAlarmStatus.cpp
  1. … 7 more files in changeset.
DEN-5833: Implementation

- Updated the old Alarm model structure to used the notify in the Message Interpreter.

- Updated the Alarm Trigger,Clear,Status to inherit from MAbstract to be able to the above.

- Added a macro to make the request messages handling easier.

    • -172
    • +32
    ./canbus/MessageInterpreter.cpp
    • -12
    • +14
    ./model/hd/alarm/MAlarmCleared.h
    • -88
    • +79
    ./model/hd/alarm/MAlarmStatusData.cpp
    • -24
    • +31
    ./model/hd/alarm/MAlarmStatusData.h
    • -12
    • +15
    ./model/hd/alarm/MAlarmTriggered.h
  1. … 2 more files in changeset.
DEN-5744: Code Review 0

- A typo to change the #3 to #4

    • -1
    • +1
    ./model/hd/data/MTreatmentStatesData.h
DEN-5744: Code Review 0

- Fixed some typo

DEN-5773: UI Unique Saline Bolus Start/Stop Enumerator

  1. … 1 more file in changeset.
DEN-5742: Code Coverage [100%]

  1. … 5 more files in changeset.
DEN-5741: Integration Testing

    • -0
    • +2
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/TreatmentStart.qml
DEN-5739: Implementation

- Added the response in cpp and qml.

  1. … 1 more file in changeset.