application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 22 Feb 21
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Feb 2021
4:26 pm

Peter Lucia <plucia@diality.com>

DEN-7041: Fixed cppcheck error

Options
    • -2
    • +2
    /sources/bluetooth/BLEScanner.h
Sunday 21 Feb 2021
10:49 pm

Peter Lucia <plucia@diality.com>

DEN-7041: Fixed compilation issues with latest common master.

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -1
    • +1
    /sources/view/hd/data/VHDTreatmentStatesData.cpp
    • -1
    • +1
    /sources/view/hd/data/VHDTreatmentStatesData.h
10:33 pm

Peter Lucia <plucia@diality.com>

DEN-7041: Fixed issues preventing tst_models from running; Fixed code coverage issues.

Options
    • -4
    • +4
    /denali.pro.user
    • -0
    • +2
    /sources/AlarmGenerator.cpp
    • -0
    • +2
    /sources/ApplicationController.cpp
    • -0
    • +2
    /sources/canbus/MessageAcknowModel.cpp
    • -0
    • +2
    /sources/canbus/MessageAcknowModel.h
    • -0
    • +2
    /sources/gui/GuiController.cpp
    • -0
    • +1
    /unittests/tst_models.h
    • -0
    • +2
    /unittests/tst_views.cpp
Monday 01 Feb 2021
2:00 pm

Peter Lucia <plucia@diality.com>

Merge DEN-4860_BLE into master

Options
    • -14
    • +11
    /cppcheck.err
    • -0
    • +1
    /scripts/run.sh
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
    • -11
    • +13
    /sources/view/VBluetooth.cpp
    • -2
    • +2
    /sources/view/VBluetooth.h
1:57 pm

Peter Lucia <plucia@diality.com>

Merge master into DEN-6349_bp_hr_manual_entry

Options
    • -10
    • +14
    /cppcheck.err
    • -102
    • +109
    /cppcheck.log
    • -0
    • +2
    /denali.pro
    • -0
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -32
    • +34
    /sources/canbus/MessageInterpreter.cpp
    • -9
    • +5
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -5
    • +16
    /sources/model/MModel.h
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -3
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +8
    /unittests/tst_models.cpp
Friday 29 Jan 2021
4:19 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments.

Options
    • -1
    • +1
    /.gitignore
Thursday 21 Jan 2021
5:21 pm

Behrouz NematiPour

Server coverage issue fixed

- This line was not covered on server although it was covered on local.

Tested locally and it is working.

Options
    • -1
    • +3
    /sources/view/hd/alarm/VAlarmStatus.cpp
1:11 pm

Behrouz NematiPour

Build failed on server because the fw common branch master was changed.

- commented out the removed enum from application.

Options
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -4
    • +4
    /sources/view/hd/data/VHDTreatmentStatesData.cpp
12:55 pm

Peter Lucia <plucia@diality.com>

Merge master into DEN-4860_BLE

Options
    • -17
    • +18
    /cppcheck.err
    • -102
    • +109
    /cppcheck.log
    • -0
    • +2
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -34
    • +36
    /sources/canbus/MessageInterpreter.cpp
    • -9
    • +5
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -5
    • +16
    /sources/model/MModel.h
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -2
    • +6
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +8
    /unittests/tst_models.cpp
Wednesday 20 Jan 2021
8:03 pm

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign'

Options
11:56 am

Peter Lucia <plucia@diality.com>

DEN-4867: Code Review 0 - Requested Modifications

- Removed startBLETimer and killBLETimer so we are not creating and deleting timers. Only one timer will be used

- Added toggleBLETimer

- Logging measurements when they are received instead of using qDebug

- Passing device addr and name to BLEScanner instead of just addr so only a QBluetoothDeviceInfo object is necessary, allowing removal of the macAddress QString

- Removed VBluetoothDeviceInfo static cast in VBluetooth::doSelectDevice

Options
    • -4
    • +4
    /denali.pro.user
    • -75
    • +57
    /sources/bluetooth/BLEScanner.cpp
    • -6
    • +2
    /sources/bluetooth/BLEScanner.h
    • -2
    • +2
    /sources/gui/qml/pages/SettingsBluetooth.qml
    • -11
    • +13
    /sources/view/VBluetooth.cpp
    • -2
    • +2
    /sources/view/VBluetooth.h
Monday 18 Jan 2021
6:32 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -1
    • +4
    /sources/view/VBluetooth.cpp
2:06 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -1
    • +7
    /sources/view/VBluetooth.cpp
    • -2
    • +3
    /sources/view/VBluetooth.h
    • -5
    • +20
    /sources/view/VVitals.cpp
    • -3
    • +7
    /sources/view/VVitals.h
Friday 15 Jan 2021
10:41 am

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -0
    • +1
    /.gitignore
    • -0
    • +10
    /denali.pro
    • -5
    • +5
    /denali.pro.user
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +5
    /sources/storage/StorageGlobals.cpp
    • -10
    • +10
    /sources/view/VBluetooth.cpp
    • -1
    • +1
    /sources/view/VBluetooth.h
10:33 am

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -0
    • +1
    /.gitignore
    • -0
    • +10
    /denali.pro
    • -5
    • +5
    /denali.pro.user
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +5
    /sources/storage/StorageGlobals.cpp
    • -10
    • +10
    /sources/view/VBluetooth.cpp
    • -1
    • +1
    /sources/view/VBluetooth.h
Thursday 14 Jan 2021
4:43 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Preventing create treatment class from thinking a new treatment profile was saved when the bledevices.conf file is updated.

Options
    • -4
    • +14
    /sources/view/VTreatmentCreate.cpp
    • -0
    • +2
    /sources/view/VTreatmentCreate.h
4:39 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -20
    • +60
    /sources/bluetooth/BLEScanner.cpp
    • -2
    • +9
    /sources/bluetooth/BLEScanner.h
Wednesday 13 Jan 2021
5:55 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -4
    • +4
    /sources/gui/qml/main.qml
4:47 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -4
    • +4
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /scripts/run.sh
    • -4
    • +0
    /sources/gui/qml/components/ScreenItem.qml
    • -21
    • +8
    /sources/gui/qml/components/SettingsItem.qml
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
10:57 am

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -2
    • +2
    /cppcheck.err
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /denali.qrc
    • -76
    • +0
    /sources/gui/qml/components/DenaliTextInput.qml
    • -1
    • +6
    /sources/gui/qml/components/Keyboard.qml
    • -0
    • +76
    /sources/gui/qml/components/TextEntry.qml
    • -28
    • +26
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -2
    • +7
    /sources/gui/qml/globals/Variables.qml
    • -4
    • +7
    /sources/gui/qml/main.qml
    • -1
    • +1
    /sources/view/VBluetooth.cpp
    • -28
    • +30
    /sources/view/VVitals.cpp
    • -21
    • +17
    /sources/view/VVitals.h
Tuesday 12 Jan 2021
5:56 pm

Behrouz NematiPour

DEN-5838: Code Review 0

Options
    • -1
    • +2
    /cr_objectives.sh
    • -1
    • +0
    /sources/model/hd/alarm/MAlarmStatusData.cpp
2:44 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Removed styling, moved keyboard to the bottom of the screen, updated text input functionality.

Options
    • -2
    • +2
    /denali.pro.user
    • -17
    • +2
    /denali.qrc
    • -1
    • +0
    /main.cpp
    • -0
    • +76
    /sources/gui/qml/components/DenaliTextInput.qml
    • -50
    • +0
    /sources/gui/qml/components/FieldInput.qml
    • -0
    • +45
    /sources/gui/qml/components/Keyboard.qml
    • -51
    • +35
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -1
    • +2
    /sources/gui/qml/globals/Colors.qml
    • -5
    • +7
    /sources/gui/qml/globals/Variables.qml
    • -23
    • +0
    /sources/gui/qml/keyboard/images/backspace-868482.svg
    • -8
    • +0
    /sources/gui/qml/keyboard/images/check-868482.svg
    • -13
    • +0
    /sources/gui/qml/keyboard/images/enter-868482.svg
    • -28
    • +0
    /sources/gui/qml/keyboard/images/globe-868482.svg
    • -18
    • +0
    /sources/gui/qml/keyboard/images/handwriting-868482.svg
    • -55
    • +0
    /sources/gui/qml/keyboard/images/hidekeyboard-868482.svg
  16. … 8 more files in changeset.
Friday 08 Jan 2021
6:51 pm

Behrouz NematiPour

DEN-5837: Code Analysis

Options
    • -5
    • +7
    /cppcheck.err
    • -94
    • +104
    /cppcheck.log
    • -0
    • +3
    /cr_objectives.sh
    • -1
    • +1
    /denali.pro.user
3:37 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 100.000% (4827/4827)

- added a unit test for the AlarmGenerator private method setBits.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -3
    • +9
    /sources/AlarmGenerator.h
    • -0
    • +17
    /unittests/tst_messaging.cpp
    • -0
    • +2
    /unittests/tst_messaging.h
1:35 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 99.979% (4826/4827)

Options
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -2
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -40
    • +41
    /sources/canbus/MessageInterpreter.cpp
    • -5
    • +16
    /sources/model/MModel.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
1:16 pm

Peter Lucia <plucia@diality.com>

DEN-6349: Updated Keyboard style and positioning

Options
    • -1
    • +1
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -0
    • +2
    /sources/gui/qml/globals/Colors.qml
    • -0
    • +1
    /sources/gui/qml/globals/Variables.qml
    • -7
    • +7
    /sources/gui/qml/keyboard/style.qml
11:16 am

Peter Lucia <plucia@diality.com>

DEN-6352: Numeric keyboard styling adjustments

Options
    • -2
    • +2
    /denali.pro.user
    • -9
    • +16
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -3
    • +3
    /sources/gui/qml/globals/Variables.qml
    • -13
    • +10
    /sources/gui/qml/keyboard/style.qml
11:08 am

Peter Lucia <plucia@diality.com>

DEN-6352: Added Qt virtualkeyboard

Options
    • -0
    • +16
    /denali.qrc
    • -0
    • +1
    /main.cpp
    • -4
    • +6
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -0
    • +23
    /sources/gui/qml/keyboard/images/backspace-868482.svg
    • -0
    • +8
    /sources/gui/qml/keyboard/images/check-868482.svg
    • -0
    • +13
    /sources/gui/qml/keyboard/images/enter-868482.svg
    • -0
    • +28
    /sources/gui/qml/keyboard/images/globe-868482.svg
    • -0
    • +18
    /sources/gui/qml/keyboard/images/handwriting-868482.svg
    • -0
    • +55
    /sources/gui/qml/keyboard/images/hidekeyboard-868482.svg
    • -0
    • +14
    /sources/gui/qml/keyboard/images/search-868482.svg
    • -0
    • +201
    /sources/gui/qml/keyboard/images/selectionhandle-bottom.svg
    • -0
    • +12
    /sources/gui/qml/keyboard/images/shift-80c342.svg
    • -0
    • +12
    /sources/gui/qml/keyboard/images/shift-868482.svg
    • -0
    • +12
    /sources/gui/qml/keyboard/images/shift-c5d6b6.svg
    • -0
    • +33
    /sources/gui/qml/keyboard/images/textmode-868482.svg
    • -0
    • +1036
    /sources/gui/qml/keyboard/style.qml
Thursday 07 Jan 2021
5:13 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- commented as manually tested the AlarmClearedCondition.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +2
    /sources/AlarmGenerator.cpp
    • -1
    • +2
    /sources/canbus/MessageInterpreter.cpp
    • -3
    • +3
    /sources/gui/GuiController.cpp
    • -1
    • +0
    /sources/gui/qml/components/TimeText.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
4:45 pm

Peter Lucia <plucia@diality.com>

DEN-6352, DEN-6353: Displaying the numeric keyboard under text input fields.

Options
    • -0
    • +2
    /main.cpp
    • -2
    • +1
    /sources/gui/qml/components/FieldInput.qml
    • -0
    • +13
    /sources/gui/qml/dialogs/VitalsEntry.qml
    • -0
    • +1
    /sources/gui/qml/globals/Variables.qml