ConcentratePumps.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-17263 addressed the code review comments

Done

Done

Done

Done

I used fabs so all are positive when monitoring is started.

I used fabs so all are positive when monitoring is started.

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

DENBUG-314 added more comment

DEN-17263 fixed the code to check the direction of the concentrate pumps and then decide based on that whether the measured speed values being negative or positive is correct or not

DEN-17263 added code to check the concentrate pumps speed direction

DENBUG-307 added code to broadcast the concentrate pumps speed the way they are regardless of the direction of the pump

DENBUG-307 made the concentrate pumps speed check all absolute to be able to check both positive and negative targets and measured speeds

DEN-17263 change the concentrate pumps speed check to not use fabs for the measured values. The target speed is checked in fabs to cover the negative target speeds

DENBUG-309 added mode flush to the 5% tolerance of the concentrate pumps speed check

DENBUG-309 changed the concnetrate pumps speed monitor to 5% in heat disinfect

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
DG-DEN-17220_Release 20 P1B Staging
DG-DEN-17220_Release 20 P1B Staging