dgfirmware / firmware / App / Controllers

ConcentratePumps.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 02 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 10 Apr
3:09 pm

Dara Navaei

Wednesday 09 Apr
4:43 pm

Michael Garthwaite and Sean Nash

Tuesday 08 Apr
2:25 pm

Dara Navaei

DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
Friday 04 Apr
3:04 pm

Dara Navaei

11:00 am

Michael Garthwaite

Wednesday 02 Apr
11:14 am

Sean Nash

11:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:13 am

Sean Nash

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

11:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Dara Navaei

DEN-17263 addressed the code review comments

Options
    • -22
    • +7
    ./ConcentratePumps.c
10:28 am

Dara Navaei

Done

Done

10:27 am

Dara Navaei

Done

Done

10:26 am

Dara Navaei

I used fabs so all are positive when monitoring is started.

I used fabs so all are positive when monitoring is started.

Tuesday 01 Apr
9:03 am

Sean Nash

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

9:01 am

Sean Nash

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

8:59 am

Sean Nash

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Tuesday 25 Mar
3:25 pm

Dara Navaei

DENBUG-314 added more comment

Options
    • -0
    • +1
    ./ConcentratePumps.c
Monday 24 Mar
1:55 pm

Dara Navaei

DEN-17263 fixed the code to check the direction of the concentrate pumps and then decide based on that whether the measured speed values being negative or positive is correct or not

Options
    • -3
    • +3
    ./ConcentratePumps.c
11:15 am

Dara Navaei

DEN-17263 added code to check the concentrate pumps speed direction

Options
    • -0
    • +11
    ./ConcentratePumps.c
9:52 am

Dara Navaei

DENBUG-307 added code to broadcast the concentrate pumps speed the way they are regardless of the direction of the pump

Options
    • -1
    • +7
    ./ConcentratePumps.c
9:41 am

Dara Navaei

DENBUG-307 made the concentrate pumps speed check all absolute to be able to check both positive and negative targets and measured speeds

Options
    • -5
    • +6
    ./ConcentratePumps.c
Friday 21 Mar
1:49 pm

Dara Navaei

DEN-17263 change the concentrate pumps speed check to not use fabs for the measured values. The target speed is checked in fabs to cover the negative target speeds

Options
    • -3
    • +4
    ./ConcentratePumps.c
Tuesday 18 Mar
3:40 pm

Dara Navaei

DENBUG-309 added mode flush to the 5% tolerance of the concentrate pumps speed check

Options
    • -3
    • +8
    ./ConcentratePumps.c
Friday 07 Mar
2:49 pm

Dara Navaei

DENBUG-309 changed the concnetrate pumps speed monitor to 5% in heat disinfect

Options
    • -6
    • +9
    ./ConcentratePumps.c
11:32 am

Dara Navaei

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
Friday 07 Feb
4:12 pm

Dara Navaei

10:03 am

jpaguio  (deleted user) and Sean Nash

Thursday 06 Feb
2:19 pm

Dara Navaei

DG-DEN-17220_Release 20 P1B Staging
DG-DEN-17220_Release 20 P1B Staging
Friday 31 Jan
4:57 pm

Dara Navaei

Thursday 30 Jan
10:39 am

Sean Nash