RinsePump.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

comments should start with capital letter

comments should start with capital letter

LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

Align comments in all of this switch cases

Align comments in all of this switch cases

Done.

Done.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Appears to be dialysate to dialyzer flow rate.

Appears to be dialysate to dialyzer flow rate.

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cas...

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cases. Consider changing variable name to something like dialysateToDialyzerFlowRate and updating function description in header to make this more clear.

0.0F.

0.0F.

Check the current Gen dialysate sub state.

Check the current Gen dialysate sub state.

Please use 0.0F (since its float variable).

Please use 0.0F (since its float variable).

LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate
LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate