dd-firmware / firmware / App / Controllers

RinsePump.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 07 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Dec
10:37 am

Michael Garthwaite

10:37 am

Michael Garthwaite

closing review. Incorrect "branched from" Should be staging_alpha

closing review. Incorrect "branched from" Should be staging_alpha

10:34 am

Michael Garthwaite

unsure. this looks like a merge from staging_alpha that isnt in staging. the code review is looking at the wrong source branch

unsure. this looks like a merge from staging_alpha that isnt in staging. the code review is looking at the wrong source branch

10:31 am

Michael Garthwaite

LEAHI-DD-FIRMWARE-LDT-1773_IOFP- Power Budget and if we need to employ the strike and hold
LEAHI-DD-FIRMWARE-LDT-1773_IOFP- Power Budget and if we need to employ the strike and hold
Friday 12 Dec
11:11 am

Sean Nash

Remove blank line.

Remove blank line.

11:05 am

Sean Nash

Should we add _TARGET to these names for clarity?

Should we add _TARGET to these names for clarity?

11:03 am

Sean Nash

Is the count really a float?

Is the count really a float?

11:02 am

Sean Nash

Do we need an override for the RPM feedback?

Do we need an override for the RPM feedback?

11:00 am

Sean Nash

This is a maximum per treatment?

This is a maximum per treatment?

9:39 am

Sean Nash

I'm not seeing fixes in this file.

I'm not seeing fixes in this file.

9:37 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:23 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:21 am

Michael Garthwaite

moved the sets into a separate function from init

moved the sets into a separate function from init

Tuesday 09 Dec
11:24 am

Dara Navaei

11:20 am

Sean Nash and Vendor - TEL - Sameer Poyil

11:19 am

Dara Navaei

11:15 am

Dara Navaei

Done

Done

11:12 am

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

Monday 08 Dec
1:02 pm

Sean Nash

Move up with other controllers.

Move up with other controllers.

Monday 03 Nov
11:04 am

Sean Nash

Thursday 16 Oct
9:52 am

Sean Nash

I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states? I would recommend we combine these 3 ...

I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states?

I would recommend we combine these 3 fpga functions into one single function that takes all 3 params and updates all 3 registers.

9:35 am

Sean Nash

I think these should be initialized to zero in case there are unused bits that won't be set below.

I think these should be initialized to zero in case there are unused bits that won't be set below.

9:30 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:26 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

Friday 10 Oct
6:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
3:55 pm

Vinayakam Mani

Tuesday 07 Oct
2:15 pm

jpaguio  (deleted user)