dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 22
Total Committers: 11
Last Commit: 12 Dec
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Dec
2:27 pm

Sean Nash

This function has an output.

This function has an output.

2:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

6:15 am

Vendor - TEL - Sameer Poyil

it can be directly initialized

it can be directly initialized

Friday 12 Dec
6:44 pm

Vendor - TEL - Sameer Poyil

use the Rinse pump API to get the flow rate

use the Rinse pump API to get the flow rate

6:43 pm

Vendor - TEL - Sameer Poyil

implement an API in RinsePump and call that API.

implement an API in RinsePump and call that API.

11:23 am

Sean Nash

No need to initialize these to zero.

No need to initialize these to zero.

11:22 am

Raghu Kallala

Something like this ( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

Something like this
( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

11:21 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:21 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:11 am

Sean Nash

Remove blank line.

Remove blank line.

11:11 am

Sean Nash

11:05 am

Sean Nash

Should we add _TARGET to these names for clarity?

Should we add _TARGET to these names for clarity?

11:03 am

Sean Nash

Is the count really a float?

Is the count really a float?

11:02 am

Sean Nash

Do we need an override for the RPM feedback?

Do we need an override for the RPM feedback?

11:00 am

Sean Nash

This is a maximum per treatment?

This is a maximum per treatment?

9:39 am

Sean Nash

I'm not seeing fixes in this file.

I'm not seeing fixes in this file.

9:37 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:23 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:21 am

Michael Garthwaite

moved the sets into a separate function from init

moved the sets into a separate function from init

9:15 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:15 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:15 am

Michael Garthwaite

LDT-1773: code review comments

Options
    • -3
    • +0
    ./Valves.c
8:56 am

Vendor - TEL - Sameer Poyil

added

added

8:56 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:56 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

8:56 am

Vendor - TEL - Sameer Poyil

added

added

8:56 am

Vendor - TEL - Sameer Poyil

removed

removed