Activity leahi-common/DDDefs.h

2 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

2 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Remove extra blank line.

3 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I don't think we need to check test config for variable initialization.

3 hrs ago

Vendor - TEL - Sameer Poyil

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

7:24 pm

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

2:17 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3344-1
started review

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.

1:01 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

12:53 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I think /// was correct. // will not be seen by doxygen.

11:03 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Not clear, why we are checking fill and supply request here?

10:24 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

10:19 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

space after if. please fix it throughout the files.

10:17 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

9:59 am