td-firmware

Clone Tools

Stats

Commits this week: 21
Total Committers: 8
Last Commit: 13:50
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vendor - TEL - Sameer Poyil

6 hrs ago

Dara Navaei

LDT-1886 fixed the valves round down the encoder to division of 8 all the time

Options
    • -8
    • +2
    /firmware/App/Controllers/Valves.c
9 hrs ago

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -31
    • +31
    /firmware/App/Controllers/Ejector.c
    • -25
    • +25
    /firmware/App/Controllers/Valves.c
    • -30
    • +30
    /firmware/App/Drivers/RotaryValve.c
9 hrs ago

Dara Navaei

Done

Done

9 hrs ago

Dara Navaei

Done

Done

9 hrs ago

Dara Navaei

Done

Done

9 hrs ago

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -37
    • +22
    /firmware/App/Controllers/Valves.c
9 hrs ago

Dara Navaei

Done

Done

9 hrs ago

Dara Navaei

Done

Done

Tuesday 16 Dec
2:55 pm

Dara Navaei

Done.

Done.

2:53 pm

Dara Navaei

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

2:17 pm

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2:15 pm

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2:13 pm

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

2:13 pm

Sean Nash

Is this temporary?

Is this temporary?

2:12 pm

Sean Nash

2:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated.

Updated.

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, we need to

Yes, we need to

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:47 pm

Dara Navaei

LDT-1886 updated the valves homing sequence

Options
    • -70
    • +159
    /firmware/App/Controllers/Valves.c
    • -0
    • +1
    /firmware/App/Controllers/Valves.h
    • -1
    • +0
    /firmware/App/Drivers/EjectorMotor.c
    • -0
    • +1
    /firmware/App/Drivers/RotaryValve.c
    • -3
    • +2
    /firmware/App/Drivers/RotaryValve.h
    • -0
    • +2
    /firmware/App/Services/AlarmMgmtSWFaults.h
1:44 pm

Sean Nash

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

1:43 pm

Sean Nash

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

1:36 pm

Sean Nash

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

1:32 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, I deleted.

Yes, I deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:01 pm

Dara Navaei

Done

Done

10:21 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:15 am

Sean Nash

MODE_TPAR should be deleted.

MODE_TPAR should be deleted.