dd-firmware / firmware / App / Controllers

DryBiCart.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 2
Last Commit: 26 Dec
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 26 Dec
2:41 pm

Vendor - TEL - Jashwant Gantyada

"LDT-2030 implemneted drain bicart state machine"

Options
    • -0
    • +231
    ./DryBiCart.c
  2. … 3 more files in changeset.
Monday 22 Dec
10:12 am

Vinayakam Mani

BiCarb related state machines will be called in pre-gen, gen dialysate and post-gen modes. currently its kept here, so any modes can set a flag to initiate the required operations.

BiCarb related state machines will be called in pre-gen, gen dialysate and post-gen modes. currently its kept here, so any modes can set a flag to initiate the required operations.

10:09 am

Vinayakam Mani

Done.

Done.

10:09 am

Vinayakam Mani

Done.

Done.

10:08 am

Vinayakam Mani

Updated.

Updated.

10:07 am

Vinayakam Mani

Done.

Done.

10:07 am

Vinayakam Mani

Done.

Done.

10:07 am

Vinayakam Mani

Done.

Done.

10:06 am

Vinayakam Mani

We will move towards 200 RPM being the minimum speed with updated Maxon controller. So, there is no need to maintain two different minimum RPM going forward.

We will move towards 200 RPM being the minimum speed with updated Maxon controller. So, there is no need to maintain two different minimum RPM going forward.

10:05 am

Vinayakam Mani

Done.

Done.

10:04 am

Vinayakam Mani

Done.

Done.

10:00 am

Vinayakam Mani

LDT-2004 code review comments

Options
    • -3
    • +2
    ./DryBiCart.c
  2. … 5 more files in changeset.
Monday 15 Dec
2:27 pm

Sean Nash

This function has an output.

This function has an output.

2:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:07 pm

Vendor - TEL - Jashwant Gantyada

LDT-2004 changes made regarding fill chamber request flag

Options
    • -1
    • +16
    ./DryBiCart.c
  2. … 2 more files in changeset.
10:23 am

Vinayakam Mani

LDT-2004 drybicarb code update

Options
    • -8
    • +11
    ./DryBiCart.c
  2. … 1 more file in changeset.
Thursday 11 Dec
2:00 pm

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

Wednesday 10 Dec
4:11 pm

Vinayakam Mani

LDT-2004 updated changes

Options
    • -13
    • +8
    ./DryBiCart.c
1:59 pm

Vendor - TEL - Jashwant Gantyada

LDT-2004-3 Made chnages top bicarb pressure check state and code adjustments.

Options
    • -6
    • +19
    ./DryBiCart.c
Tuesday 09 Dec
5:19 pm

Vinayakam Mani

LDT-2004 drybicarb changes

Options
    • -2
    • +5
    ./DryBiCart.c
  2. … 2 more files in changeset.
10:27 am

Sean Nash

Shouldn't EVERY state set ALL valves?

Shouldn't EVERY state set ALL valves?

Monday 08 Dec
7:02 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

7:00 pm

Vendor - TEL - Sameer Poyil

Let public function on top

Let public function on top

6:53 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

6:52 pm

Vendor - TEL - Sameer Poyil

Mixing static and public function , let public function comes on top

Mixing static and public function , let public function comes on top

6:50 pm

Vendor - TEL - Sameer Poyil

comment should start with capital letter

comment should start with capital letter

2:52 pm

Vinayakam Mani

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

These set of valves defined as per system architecture (to make sure all valves initialized as expected).