td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

Yes, updated

Yes, updated

Removed

Removed

Remove blank line.

Remove blank line.

Looks like this reverted back.

Looks like this reverted back.

input parameter not updated

input parameter not updated

input parameter is not updated

input parameter is not updated

input and output is not updated properly

input and output is not updated properly

structure packing required

structure packing required

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
Yes, we do and this is not required here so, I removed

Yes, we do and this is not required here so, I removed

Shouldn't we be getting these defaults from the TxParams unit?

Shouldn't we be getting these defaults from the TxParams unit?

Yes, Updated

Yes, Updated

I think this should be commented out before we merge to staging.

I think this should be commented out before we merge to staging.

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
Updated

Updated

Updated

Updated

Format for params is: param name description Add "psi" (name) between param and "Pressure value in PSI".

Format for params is: param name description
Add "psi" (name) between param and "Pressure value in PSI".

I removed

I removed

Sorry, updated

Sorry, updated

done.

done.

LDT-2749 addressed code review comments

Please keep local declarations together up top.

Please keep local declarations together up top.

removed.

removed.