leahi-fwcommon

Clone Tools

Stats

Commits this week: 15
Total Committers: 10
Last Commit: 10:02
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
10 mins ago

Sean Nash

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

2 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Yes, updated

Yes, updated

2 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

2 hrs ago

Sean Nash

Looks like this reverted back.

Looks like this reverted back.

2 hrs ago

Raghu Kallala

2 hrs ago

Sean Nash , Vinayakam Mani and Michael Garthwaite

3 hrs ago

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

4 hrs ago

Raghu Kallala

LDT-3343 removed duplicate test config for rinse pump

Options
    • -2
    • +1
    /TestSupport.h
7 hrs ago

Raghu Kallala

Updated

Updated

7 hrs ago

Raghu Kallala

Fixed

Fixed

Tuesday 03 Feb
5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

3:12 pm

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

3:00 pm

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

2:59 pm

Sean Nash

Remove blank line.

Remove blank line.

2:04 pm

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

1:45 pm

Vendor - TEL - Sameer Poyil

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

11:43 am

Sean Nash

8:45 am

Raghu Kallala

LDT-3343 added test config to run DD alone

Options
    • -0
    • +1
    /TestSupport.h
Monday 02 Feb
3:41 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:39 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:17 pm

Vendor - TEL - Sameer Poyil

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

2:15 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
2:02 pm

Sean Nash

Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

1:55 pm

Sean Nash

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

1:30 pm

Sean Nash

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
1:24 pm

Vendor - TEL - Varshini Nagabooshanam

1:14 pm

Vendor - TEL - Jashwant Gantyada

11:42 am

Vendor - TEL - Varshini Nagabooshanam

Yes, we do and this is not required here so, I removed

Yes, we do and this is not required here so, I removed