leahi-common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Plan is for 4 wire and currently there is no data for both 2 wire and 4 wire . So its TODO list and hence mark it as resolved

Plan is for 4 wire and currently there is no data for both 2 wire and 4 wire . So its TODO list and hence mark it as resolved

Plan is for 4 wire and currently there is no data for both 2 wire and 4 wire . So its TODO list and hence mark it as resolved

Plan is for 4 wire and currently there is no data for both 2 wire and 4 wire . So its TODO list and hence mark it as resolved

Done.

Done.

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

Declarations should be at top of scope.

Declarations should be at top of scope.

Is this temporary?

Is this temporary?

Add blank line between declarations and statements.

Add blank line between declarations and statements.

Add blank line between declarations and statements.

Add blank line between declarations and statements.

Updated.

Updated.

Yes, we need to

Yes, we need to

Deleted.

Deleted.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Yes, I deleted.

Yes, I deleted.

Deleted.

Deleted.

Removed

Removed

Deleted.

Deleted.

Done

Done

Removed

Removed

Removed

Removed