Activity leahi-fwcommon/TestSupport.h

3 hrs ago

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3344-1
started review

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.

4 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

4 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I think /// was correct. // will not be seen by doxygen.

6 hrs ago

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

6 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Not clear, why we are checking fill and supply request here?

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

space after if. please fix it throughout the files.

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Please introduce test config for drybicart selection.

4:57 pm

Vendor - TEL - Varshini Nagabooshanam

4:53 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-1415-1
finished reviewing

4:36 pm

Vendor - TEL - Varshini Nagabooshanam

More
LEAHI-TD-FIRMWARE-LDT-1415-1
started review

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

3:38 pm

Vinayakam Mani

Done.

3:38 pm

Vinayakam Mani

Done

3:37 pm

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

3:36 pm

Vinayakam Mani

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

2:34 pm