BalancingChamber.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

align the comment

align the comment

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

Yes. updated.

Yes. updated.

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

Done.

Done.

Done

Done

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

What should trimmer heater be doing in these spent/bicarb chamber states?

What should trimmer heater be doing in these spent/bicarb chamber states?

I would think this would be enabled by default.

I would think this would be enabled by default.

LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD
LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD
LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

Align comments in all of this switch cases

Align comments in all of this switch cases

Done.

Done.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Done

Done

Done

Done