dd-firmware / firmware / App / Controllers

ROPump.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 09:42
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 23 Jan
1:07 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ROPump.c
1:03 pm

Michael Garthwaite

1:02 pm

Sean Nash and Raghu Kallala

12:55 pm

Michael Garthwaite

LDT-2977: code review adjust

Options
    • -2
    • +0
    ./ROPump.c
12:51 pm

Michael Garthwaite

fixed.

fixed.

12:51 pm

Michael Garthwaite

LDT-2977: code review comments.

Options
    • -0
    • +5
    ./ROPump.c
12:49 pm

Michael Garthwaite

LDT-2977: code review comments.

Options
    • -2
    • +2
    ./ROPump.c
12:48 pm

Sean Nash

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

12:09 pm

Michael Garthwaite

fixed for both _TO_PWM macros

fixed for both _TO_PWM macros

12:09 pm

Michael Garthwaite

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

12:08 pm

Michael Garthwaite

LDT-2977: code review updates. Removed macro for flow that used counts

Options
    • -6
    • +4
    ./ROPump.c
12:06 pm

Michael Garthwaite

Merge branch 'staging' into LDT-2977-iofp-update

Options
    • -19
    • +51
    ./ROPump.c
9:52 am

Sean Nash

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

9:49 am

Sean Nash

I don't see this macro being used anywhere.

I don't see this macro being used anywhere.

Wednesday 21 Jan
10:13 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ROPump.c
  2. … 3 more files in changeset.
10:10 am

Raghu Kallala

9:46 am

Michael Garthwaite

Tuesday 20 Jan
2:19 pm

Sean Nash

2:15 pm

Raghu Kallala

LDT-1925 addressed review comments

Options
    • -8
    • +8
    ./ROPump.c
  2. … 3 more files in changeset.
2:14 pm

Raghu Kallala

Updated

Updated

2:14 pm

Raghu Kallala

Added

Added

2:14 pm

Raghu Kallala

Updated

Updated

2:14 pm

Raghu Kallala

Fixed

Fixed

2:12 pm

Sean Nash

TRUE if low flow alarm is exempt, FALSE if not.

TRUE if low flow alarm is exempt, FALSE if not.

2:08 pm

Sean Nash

timeSinceP12Started?

timeSinceP12Started?

2:07 pm

Sean Nash

Should we have a comment for this one too?

Should we have a comment for this one too?

2:07 pm

Sean Nash

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

1:43 pm

Raghu Kallala

Updated to use isPersistentAlarmTriggered

Updated to use isPersistentAlarmTriggered

1:43 pm

Raghu Kallala

Fixed

Fixed

1:43 pm

Raghu Kallala

Updated

Updated