RinsePump.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

It's Beta 1.9.

It's Beta 1.9.

Done

Done

Ok they were declared twice. Done.

Ok they were declared twice. Done.

Not what I mean. I mean lines 174 and 193 are identical copies.

Not what I mean. I mean lines 174 and 193 are identical copies.

Then the FPGA get function seems mis-named. Pulse width is not really the same as speed. It is the inverse of frequency, which can be converted to speed.

Then the FPGA get function seems mis-named. Pulse width is not really the same as speed. It is the inverse of frequency, which can be converted to speed.

It is speed as pulse width modulation.

It is speed as pulse width modulation.

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

Does this function return a speed or a pulse width?

Does this function return a speed or a pulse width?

These 2 functions seem redundant (with same prototypes above).

These 2 functions seem redundant (with same prototypes above).

LEAHI-DD-FIRMWARE-LDT-2801_Add 4-wire rinse pump commands
LEAHI-DD-FIRMWARE-LDT-2801_Add 4-wire rinse pump commands
Done

Done

comments should start with capital letter

comments should start with capital letter

LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

Align comments in all of this switch cases

Align comments in all of this switch cases