dd-firmware / firmware / App / Controllers

Valves.h

Clone Tools

Stats

Commits this week: 4
Total Committers: 6
Last Commit: 15:46
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Feb
11:34 am

Raghu Kallala

11:30 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

6:24 am

Raghu Kallala

Updated

Updated

6:23 am

Raghu Kallala

Fixed

Fixed

Tuesday 03 Feb
5:02 pm

Vendor - TEL - Sameer Poyil

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()

5:01 pm

Vendor - TEL - Sameer Poyil

is it possible to use the function u32ArrayOverride() here ?

is it possible to use the function u32ArrayOverride() here ?

4:48 pm

Sean Nash

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

4:41 pm

Sean Nash

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

4:38 pm

Sean Nash

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.

3:00 pm

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

2:59 pm

Sean Nash

Remove blank line.

Remove blank line.

2:21 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
Monday 02 Feb
2:15 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
Friday 14 Nov 2025
5:03 pm

Sean Nash

3:19 pm

Raghu Kallala , Vinayakam Mani and Dara Navaei

11:24 am

Dara Navaei

Done

Done

11:23 am

Dara Navaei

No I removed it.

No I removed it.

10:56 am

Sean Nash

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

Thursday 13 Nov 2025
9:56 am

Michael Garthwaite

fixed. thanks

fixed. thanks

9:15 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should be a s...

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:09 am

Michael Garthwaite

fixed. thanks

fixed. thanks

Wednesday 12 Nov 2025
10:28 pm

Sean Nash

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

3:23 pm

Michael Garthwaite

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

3:23 pm

Michael Garthwaite

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

1:51 pm

Michael Garthwaite

reworked to use the request stop functions in their respective op modes.

reworked to use the request stop functions in their respective op modes.

1:51 pm

Michael Garthwaite

reworked to use the request functions we have in the respective op modes. They check the standby constraint

reworked to use the request functions we have in the respective op modes. They check the standby constraint

1:50 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:50 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!