dd-firmware / firmware / App

DDCommon.h

Clone Tools

Stats

Commits this week: 12
Total Committers: 9
Last Commit: 15:46
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Vendor - TEL - Sameer Poyil

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

3 hrs ago

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

7 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
10 hrs ago

Sean Nash

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

10 hrs ago

Sean Nash

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

12 hrs ago

Vinayakam Mani

Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

12 hrs ago

Vinayakam Mani

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

12 hrs ago

Vinayakam Mani

space after if. please fix it throughout the files.

space after if. please fix it throughout the files.

12 hrs ago

Vinayakam Mani

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

13 hrs ago

Vinayakam Mani

Please introduce test config for drybicart selection.

Please introduce test config for drybicart selection.

13 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
Wednesday 04 Feb
3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done

Done

3:37 pm

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

3:36 pm

Vinayakam Mani

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

1:29 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
11:43 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
10:24 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

Tuesday 03 Feb
5:32 pm

Sean Nash

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task...

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task, we could have situation where data is retrieved, then priority task updates fpga, and then counter is retrieved with wrong (incremented) counter.
If these two functions are being called from a driver that is executed in priority task, then we don't need to worry about this situation, but still ought to add a constraint/warning comment in function headers noting that these functions should only be called from priority task.

5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

5:16 pm

Sean Nash

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

5:15 pm

Sean Nash

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function...

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function (assuming shared enum to index)?

5:14 pm

Sean Nash

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler wher...

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler where they are all in one place and could be indexed by enum with single command.

5:09 pm

Sean Nash

Do we need to say Value?

Do we need to say Value?

5:08 pm

Sean Nash

Add a blank line after public defs banner. Add a dox comment to the right. I believe they reserve space for 12 bytes, not 10. Not really for calibration - it's for s/n and versions.

Add a blank line after public defs banner.
Add a dox comment to the right.
I believe they reserve space for 12 bytes, not 10.
Not really for calibration - it's for s/n and versions.

5:06 pm

Sean Nash

Are these really going to be different types? I assumed they would all be floats.

Are these really going to be different types? I assumed they would all be floats.

5:05 pm

Sean Nash

Structures need a top level dox comment.

Structures need a top level dox comment.

5:05 pm

Sean Nash

enums need a top level dox comment.

enums need a top level dox comment.

4:56 pm

Sean Nash

I believe conductivity and temperature data will be F32s.

I believe conductivity and temperature data will be F32s.