dd-firmware / firmware / App / Drivers

BloodLeakDriver.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 1
Last Commit: 05 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Feb
10:53 am

Vendor - TEL - Jashwant Gantyada

LDT-2030 removed static variables to update the values used by monitor and driver

Options
    • -7
    • +9
    ./BloodLeakDriver.c
  2. … 2 more files in changeset.
Monday 02 Feb
9:35 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:35 am

Sean Nash

Remove blank line.

Remove blank line.

9:34 am

Sean Nash

Remove blank line.

Remove blank line.

9:33 am

Sean Nash

Remove blank line.

Remove blank line.

Monday 12 Jan
10:29 am

Sean Nash

9:10 am

Sean Nash

Ah, I see it now. But we haven't really addressed my original comment. I will resolve for now, but keep in mind that I'd like to avoid this kind of sequencing where we are declaring local variables...

Ah, I see it now. But we haven't really addressed my original comment. I will resolve for now, but keep in mind that I'd like to avoid this kind of sequencing where we are declaring local variables below statements like on 948.

8:44 am

Dara Navaei

It is defined in line 937.

It is defined in line 937.

Sunday 11 Jan
9:14 pm

Sean Nash

Well now you're using cmdSpec and I don't see where it's declared. Does this compile now?

Well now you're using cmdSpec and I don't see where it's declared. Does this compile now?

Wednesday 07 Jan
4:14 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

4:14 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

4:13 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

4:13 pm

Vendor - TEL - Jashwant Gantyada

removed all.

removed all.

4:13 pm

Vendor - TEL - Jashwant Gantyada

followed the pattern.

followed the pattern.

4:13 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

done. changed.

done. changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:11 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:10 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:10 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

4:08 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030-2 addressed code review comments

Options
    • -8
    • +11
    ./BloodLeakDriver.c
  2. … 4 more files in changeset.
1:22 pm

Sean Nash

Should only have one exit for a function at end of function (per our coding standards).

Should only have one exit for a function at end of function (per our coding standards).

1:22 pm

Sean Nash

Add space between (( and )).

Add space between (( and )).

1:20 pm

Sean Nash

We should always include the s/w fault ID and a supporting data (in this case, maybe cmd) with s/w fault alarms.

We should always include the s/w fault ID and a supporting data (in this case, maybe cmd) with s/w fault alarms.