dd-firmware / firmware / App / Monitors

WaterQualityMonitor.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 15:46
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Jan
10:43 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./WaterQualityMonitor.c
  2. … 5 more files in changeset.
10:41 am

Raghu Kallala

10:38 am

Vinayakam Mani and Michael Garthwaite

Tuesday 27 Jan
12:53 pm

Raghu Kallala

resolved

resolved

11:50 am

Vinayakam Mani

SPENT_CHAMBER_H_FILL

SPENT_CHAMBER_H_FILL

10:53 am

Raghu Kallala

LDT-3160 updated code for enable spent chamber fill test config

Options
    • -3
    • +3
    ./WaterQualityMonitor.c
  2. … 1 more file in changeset.
Monday 26 Jan
9:12 am

Raghu Kallala

LDT-3160 skipped conductivity alarms for FP with test config

Options
    • -3
    • +12
    ./WaterQualityMonitor.c
Wednesday 21 Jan
11:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3160_Beta Dialin Test Configs Needed
LEAHI-DD-FIRMWARE-LDT-3160_Beta Dialin Test Configs Needed
10:13 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./WaterQualityMonitor.c
  2. … 3 more files in changeset.
10:10 am

Raghu Kallala

9:46 am

Michael Garthwaite

Tuesday 20 Jan
2:19 pm

Sean Nash

2:15 pm

Raghu Kallala

LDT-1925 addressed review comments

Options
    • -1
    • +1
    ./WaterQualityMonitor.c
  2. … 3 more files in changeset.
2:14 pm

Raghu Kallala

Updated

Updated

2:14 pm

Raghu Kallala

Added

Added

2:14 pm

Raghu Kallala

Updated

Updated

2:14 pm

Raghu Kallala

Fixed

Fixed

2:12 pm

Sean Nash

TRUE if low flow alarm is exempt, FALSE if not.

TRUE if low flow alarm is exempt, FALSE if not.

2:08 pm

Sean Nash

timeSinceP12Started?

timeSinceP12Started?

2:07 pm

Sean Nash

Should we have a comment for this one too?

Should we have a comment for this one too?

2:07 pm

Sean Nash

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

1:43 pm

Raghu Kallala

Updated to use isPersistentAlarmTriggered

Updated to use isPersistentAlarmTriggered

1:43 pm

Raghu Kallala

Fixed

Fixed

1:43 pm

Raghu Kallala

Updated

Updated

1:42 pm

Raghu Kallala

Updated

Updated

1:42 pm

Raghu Kallala

Changed the implementation

Changed the implementation

1:42 pm

Raghu Kallala

Fixed

Fixed

1:41 pm

Raghu Kallala

LDT-1925 restructed the code per SRS behavior

Options
    • -9
    • +9
    ./WaterQualityMonitor.c
  2. … 3 more files in changeset.
9:58 am

Sean Nash

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control? And why aren't we resetting exempt flag in same place as timer?

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control?
And why aren't we resetting exempt flag in same place as timer?

9:57 am

Sean Nash

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.