dd-firmware

firmware

Clone Tools

Stats

Commits this week: 47
Total Committers: 15
Last Commit: 15:46
Commits this week: 47

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
2 hrs ago

Dara Navaei

Merged staging

Options
    • -2
    • +43
    ./App/Controllers/Valves.c
    • -1
    • +11
    ./App/Controllers/Valves.h
    • -4
    • +15
    ./App/Modes/ModeStandby.c
    • -2
    • +3
    ./App/Services/AlarmMgmtSWFaults.h
    • -3
    • +3
    ./App/Services/TDInterface.c
3 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
4 hrs ago

Sean Nash

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

4 hrs ago

Sean Nash

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

6 hrs ago

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

6 hrs ago

Vinayakam Mani

Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

7 hrs ago

Vinayakam Mani

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

7 hrs ago

Vinayakam Mani

space after if. please fix it throughout the files.

space after if. please fix it throughout the files.

7 hrs ago

Vinayakam Mani

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

7 hrs ago

Vinayakam Mani

Please introduce test config for drybicart selection.

Please introduce test config for drybicart selection.

7 hrs ago

Sean Nash

8 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
8 hrs ago

Vendor - TEL - Arpita Srivastava

Merge branch 'LDT-3222-command-to-override-all-BC' into develop

Options
    • -6
    • +26
    ./App/Controllers/Valves.c
8 hrs ago

Vendor - TEL - Arpita Srivastava

LDT-3222: Added call to convert valve states to values

Options
    • -3
    • +3
    ./App/Controllers/Valves.c
Wednesday 04 Feb
3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done

Done

3:37 pm

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

3:36 pm

Vinayakam Mani

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

1:29 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
11:43 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
11:36 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/PermeateTank.c
    • -2
    • +2
    ./App/Controllers/RinsePump.c
    • -2
    • +2
    ./App/Controllers/Valves.c
    • -1
    • +1
    ./App/Controllers/Valves.h
    • -2
    • +2
    ./App/Modes/FPModes/ModePreGenPermeate.c
    • -2
    • +2
    ./App/Modes/ModeStandby.c
    • -2
    • +2
    ./App/Modes/ModeStandby.h
    • -2
    • +2
    ./App/Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./App/Services/TDInterface.c
11:34 am

Raghu Kallala

11:30 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

10:53 am

Vendor - TEL - Jashwant Gantyada

LDT-2030 removed static variables to update the values used by monitor and driver

Options
    • -7
    • +9
    ./App/Drivers/BloodLeakDriver.c
    • -1
    • +1
    ./App/Drivers/BloodLeakDriver.h
    • -44
    • +1
    ./App/Monitors/BloodLeak.c
10:24 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

10:03 am

Raghu Kallala

LDT-3343 added condition for DD to wait for FP to start preGen

Options
    • -2
    • +2
    ./App/Controllers/RinsePump.c
    • -4
    • +12
    ./App/Modes/ModeStandby.c
6:25 am

Raghu Kallala

LDT-3343 updated function header

Options
    • -2
    • +1
    ./App/Controllers/Valves.c
6:24 am

Raghu Kallala

Updated

Updated

6:23 am

Raghu Kallala

Fixed

Fixed