firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merged staging

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

space after if. please fix it throughout the files.

space after if. please fix it throughout the files.

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

Please introduce test config for drybicart selection.

Please introduce test config for drybicart selection.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'LDT-3222-command-to-override-all-BC' into develop

LDT-3222: Added call to convert valve states to values

Done.

Done.

Done

Done

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    ./App/Modes/FPModes/ModePreGenPermeate.c
LDT-2030 removed static variables to update the values used by monitor and driver

Fixed it

Fixed it

LDT-3343 added condition for DD to wait for FP to start preGen

LDT-3343 updated function header

Updated

Updated

Fixed

Fixed