leahi-dialin / leahi_dialin / dd

dialysate_delivery.py

Clone Tools

Stats

Commits this week: 4
Total Committers: 9
Last Commit: 09 Feb
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Feb
8:57 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:01 pm

Vendor - TEL - Sameer Poyil

5:55 pm

Vendor - TEL - Sameer Poyil

This is a change from Zoltan and I am updated that into my local branch

This is a change from Zoltan and I am updated that into my local branch

4:20 pm

Sean Nash

Friday 06 Feb
8:18 pm

Vendor - TEL - Sameer Poyil

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

8:15 pm

Vendor - TEL - Sameer Poyil

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

10:41 am

Sean Nash

Add a blank line between functions.

Add a blank line between functions.

9:37 am

Sean Nash

Is this staying? Is all of above replacing this class?

Is this staying? Is all of above replacing this class?

Thursday 05 Feb
1:26 pm

Michael Garthwaite

WIP on develop

LDT-3287: added message sent for TD. trimmed documentation

Options
    • -1
    • +1
    ./dialysate_delivery.py
  2. … 2 more files in changeset.
11:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
11:27 am

Michael Garthwaite

LDT-3287: Added an initial message that is sent on class object construction for FP & DD to allow the subsystem to start publishing as the subsystem may assume no one is on the CANbus when dialin is a node.

Options
    • -0
    • +10
    ./dialysate_delivery.py
  2. … 1 more file in changeset.
Tuesday 03 Feb
2:58 pm

Zoltan Miskolci and Michael Garthwaite

2:05 pm

Zoltan Miskolci

Based on the msg id, it should be here

Based on the msg id, it should be here

1:30 pm

Vendor - TEL - Sameer Poyil

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

9:09 am

Zoltan Miskolci

Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

Monday 02 Feb
4:00 pm

Sean Nash

Thursday 22 Jan
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -60
    • +60
    ./dialysate_delivery.py
  2. … 46 more files in changeset.
Wednesday 21 Jan
8:02 pm

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into develop

Options
    • -60
    • +60
    ./dialysate_delivery.py
  2. … 46 more files in changeset.
12:35 pm

Sean Nash

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

Monday 19 Jan
11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

11:48 am

Michael Garthwaite

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique ke...

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).

10:46 am

Zoltan Miskolci

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how...

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how much to shift value for it.
Making an alias is more dynamic and not needing separate variables to be maintained for this.

10:42 am

Zoltan Miskolci

Enum content of Beta 1.0 and Beta 1.9 is different. The new sensors messing up the order for the old HW's override and broadcast data allocation. Making it dynamic makes it that when the beta test ...

Enum content of Beta 1.0 and Beta 1.9 is different. The new sensors messing up the order for the old HW's override and broadcast data allocation.
Making it dynamic makes it that when the beta test config is called the enums are switching content to reflect that.