conductivity_sensors.py

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'LDT-2787-fp_dd_proxy_commands' into develop

  1. … 3 more files in changeset.
Merge branch 'staging' into LDT-2004-dialysate-composition-dd

updated to use the generic override. Both of you are correct, the generic override can be used. Since we pack the payload outside of the generic override, for this situation we don't pack the res...

updated to use the generic override.

Both of you are correct, the generic override can be used.

Since we pack the payload outside of the generic override, for this situation we don't pack the reset byte and therefore will stay as a U32 which satisfies the FW constraint. The other concern I had was that the FW would not reply back with a test ACK back to dialin with this cmd, thus causing a timeout in the generic override function. This is address as all messages in the lookup table in FW will reply back with a test ACK.

Therefore im okay using the generic override method

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

Merge branch 'LDT-2998-update-dialin-to-support-any-b1' into develop

  1. … 12 more files in changeset.
It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue. you are sending a message with this msg id and this p...

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?

LDT-2004: updated to use generic override.

fixed writing over the error count override. Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_...

fixed writing over the error count override.

Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_T.

the generic override will cause the FW to always reject the value since the payload size is not what is expected.

LDT-2004: fixed overrwriting error count override. Renamed set conductivity model method.

Can't we use the generic override? You just need to update 3 fields: msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST entity_name = 'DD Coductivity sensor model request' override_text = 'S...

Can't we use the generic override?
You just need to update 3 fields:

msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST
entity_name = 'DD Coductivity sensor model request'
override_text = 'Sent' or ''

LDT-2004: implementation for set conductivity model

  1. … 1 more file in changeset.
LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
- Removed HW flag from broadcast as FW doesn't change broadcast content based on HW flag

  1. … 6 more files in changeset.
Merge branch 'LDT-3214-override-refactor' into staging

  1. … 46 more files in changeset.
Merge branch 'LDT-3214-override-refactor' into develop

  1. … 46 more files in changeset.
Merge branch 'LDT-611-fp-add-ability-to-override-tempe' into develop

  1. … 10 more files in changeset.
I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.