leahi-dialin / leahi_dialin / dd / modules

conductivity_sensors.py

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 14:19
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Feb
8:40 am

Zoltan Miskolci

Merge branch 'LDT-2787-fp_dd_proxy_commands' into develop

Options
    • -2
    • +28
    ./conductivity_sensors.py
  2. … 3 more files in changeset.
Tuesday 27 Jan
10:07 am

Michael Garthwaite

10:07 am

Michael Garthwaite

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

Options
    • -8
    • +3
    ./conductivity_sensors.py
9:24 am

Zoltan Miskolci

9:20 am

Michael Garthwaite

updated to use the generic override. Both of you are correct, the generic override can be used. Since we pack the payload outside of the generic override, for this situation we don't pack the res...

updated to use the generic override.

Both of you are correct, the generic override can be used.

Since we pack the payload outside of the generic override, for this situation we don't pack the reset byte and therefore will stay as a U32 which satisfies the FW constraint. The other concern I had was that the FW would not reply back with a test ACK back to dialin with this cmd, thus causing a timeout in the generic override function. This is address as all messages in the lookup table in FW will reply back with a test ACK.

Therefore im okay using the generic override method

Monday 26 Jan
10:46 pm

Sean Nash

10:45 pm

Sean Nash

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

4:51 pm

Zoltan Miskolci

4:38 pm

Zoltan Miskolci

Merge branch 'LDT-2998-update-dialin-to-support-any-b1' into develop

Options
    • -7
    • +3
    ./conductivity_sensors.py
  2. … 12 more files in changeset.
4:19 pm

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

3:13 pm

Zoltan Miskolci

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue. you are sending a message with this msg id and this p...

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?

2:29 pm

Michael Garthwaite

LDT-2004: updated to use generic override.

Options
    • -6
    • +9
    ./conductivity_sensors.py
12:31 pm

Michael Garthwaite

fixed writing over the error count override. Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_...

fixed writing over the error count override.

Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_T.

the generic override will cause the FW to always reject the value since the payload size is not what is expected.

12:28 pm

Michael Garthwaite

LDT-2004: fixed overrwriting error count override. Renamed set conductivity model method.

Options
    • -1
    • +25
    ./conductivity_sensors.py
12:26 pm

Zoltan Miskolci

Can't we use the generic override? You just need to update 3 fields: msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST entity_name = 'DD Coductivity sensor model request' override_text = 'S...

Can't we use the generic override?
You just need to update 3 fields:

msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST
entity_name = 'DD Coductivity sensor model request'
override_text = 'Sent' or ''

12:18 pm

Michael Garthwaite

LDT-2004: implementation for set conductivity model

Options
    • -22
    • +21
    ./conductivity_sensors.py
  2. … 1 more file in changeset.
12:16 pm

Dara Navaei

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
Friday 23 Jan
3:18 pm

Michael Garthwaite

11:42 am

Zoltan Miskolci

- Removed HW flag from broadcast as FW doesn't change broadcast content based on HW flag

Options
    • -8
    • +3
    ./conductivity_sensors.py
  2. … 6 more files in changeset.
Thursday 22 Jan
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -104
    • +48
    ./conductivity_sensors.py
  2. … 46 more files in changeset.
Wednesday 21 Jan
8:02 pm

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into develop

Options
    • -78
    • +42
    ./conductivity_sensors.py
  2. … 46 more files in changeset.
12:35 pm

Sean Nash

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

2:54 pm

Zoltan Miskolci

Merge branch 'LDT-611-fp-add-ability-to-override-tempe' into develop

Options
    • -15
    • +24
    ./conductivity_sensors.py
  2. … 10 more files in changeset.
10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.