Activity leahi-dialin/leahi

3:38 pm

Dara Navaei

More
Re: LEAHI-DIALIN-LDT-3350-1
commented on review

Did we not decide to revert all the changes back and the redesign the whole concept again?

3:35 pm

Behrouz NematiPour

More
LEAHI-DIALIN-LDT-3350-1
finished reviewing

3:05 pm

Zoltan Miskolci

More
41de945
changed 8 files
LDT-3350-add_from_str, develop LEAHI-DIALIN-LDT-3350-1

- Removed ignore and _str_list from base class, added empty _str_list to all childs to not throw an error when from_str is called on them

- -0
- +1
./alarms.py
- History
- Source
- Diff
./alarms.py
… 7 more files in changeset.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

3:54 pm

Behrouz NematiPour

This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

3:54 pm

This is incorrect. We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use. We will keep it for now to unblock the rest of the...

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

2:27 pm

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

2:25 pm

Zoltan Miskolci

removed commented out line

2:24 pm

Zoltan Miskolci

More
5476322
changed 1 file
LDT-3350-add_from_str, develop LEAHI-DIALIN-LDT-3350-1

removed

- -1
- +0
./events.py
- History
- Source
- Diff
./events.py

2:20 pm

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

2:20 pm

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

2:15 pm

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

2:12 pm