This is a list of all comments for DD-LDT-1735-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BalancingChamber.c
Revision Comment by Vinayakam Mani on 22 August 2025, 15:41 
https://devapps.diality.us/cru/DD-LDT-1735-1#c23856

  Add open and close parenthesis.

  Reply by ven.smathamala on 25 August 2025, 11:49
  > Fixed.

Revision Comment by Vinayakam Mani on 22 August 2025, 16:04 
https://devapps.diality.us/cru/DD-LDT-1735-1#c23857

  It should be equal to true?
  
  ( getTestConfigStatus( TEST_CONFIG_DISABLE_BC_PRESSURE_ALARMS )
  == TRUE )

  Reply by ven.smathamala on 25 August 2025, 11:51
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/PressureSensor.c
Revision Comment by Sean Nash on 22 August 2025, 13:30 
https://devapps.diality.us/cru/DD-LDT-1735-1#c23850

  Beta and Alpha are swapped here.  Beta should be -14.... and
  Alpha should be 0.0.

  Reply by ven.smathamala on 25 August 2025, 11:53
  > Swapped.

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Vinayakam Mani on 29 August 2025, 10:36 
https://devapps.diality.us/cru/DD-LDT-1735-1#c23971

  I guess, you should still need 'TestingActivated' check, due to
  a reason when system team wants to change the states as part of
  their testing.

  Reply by Sean Nash on 29 August 2025, 11:05
  > Fixed.

----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.c
Revision Comment by Vinayakam Mani on 29 August 2025, 10:34 
https://devapps.diality.us/cru/DD-LDT-1735-1#c23970

  timePerStep is not initialized with the values and being used
  here.

  Reply by ven.smathamala on 29 August 2025, 10:51
  > Fixed .


---

ID: DD-LDT-1735-1 https://devapps.diality.us/cru/DD-LDT-1735-1

Title: DD-LDT-1735_Test Config Support For DD
Statement of Objectives:


State: Closed

Summary: 

Author: ven.smathamala
Moderator: ven.smathamala
Reviewers: (6 active, 2 completed*)
     Sean Nash   (*)
     Vinayakam Mani   (*)
     jpaguio
     Michael Garthwaite
     Raghu Kallala
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho