This is a list of all comments for DG-DEN-13427-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/LoadCell.c
Revision Comment by wbracken on 29 August 2022, 17:08 
https://devapps.diality.us/cru/DG-DEN-13427-1#c13600

  Align on "*" maybe?

  Reply by Michael Garthwaite on 07 September 2022, 10:19
  > Fixed. Thanks!

    Reply by wbracken on 07 September 2022, 17:16
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeService.c
Revision Comment by Sean Nash on 25 August 2022, 17:41 
https://devapps.diality.us/cru/DG-DEN-13427-1#c13559

  Remove blank line.

  Reply by Michael Garthwaite on 07 September 2022, 10:19
  > Fixed. Thanks!

    Reply by Sean Nash on 07 September 2022, 17:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by wbracken on 09 September 2022, 10:04 
https://devapps.diality.us/cru/DG-DEN-13427-1#c13729

  Header needs to be updated

  Reply by Michael Garthwaite on 09 September 2022, 13:55
  > This block of code is being flagged as a change into my
  > branch but it is not reflected on either commit listed above.
  > Header will be updated in DEN-13801 branch.

    Reply by wbracken on 12 September 2022, 15:32
    > RESOLVED IN CODE WALKTRHOUGH

----------------------------------------
File: firmware/App/Services/SystemCommMessages.h
Revision Comment by Sean Nash on 25 August 2022, 17:43 
https://devapps.diality.us/cru/DG-DEN-13427-1#c13560

  Send functions usually return a BOOL.

  Reply by Michael Garthwaite on 07 September 2022, 10:19
  > Fixed. Thanks!

    Reply by Sean Nash on 07 September 2022, 17:10
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-13427-1 https://devapps.diality.us/cru/DG-DEN-13427-1

Title: DG-DEN-13427_SW Dev Sprint 75 MG
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Dong Nguyen