This is a list of all comments for DG-DEN-14000-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Drivers/CPLD.c
Revision Comment by Michael Garthwaite on 21 November 2022, 16:43 
https://devapps.diality.us/cru/DG-DEN-14000-1#c15013

  Does CPLD need to include sys comm?

  Reply by Dara Navaei on 21 November 2022, 16:50
  > Done.

    Reply by Michael Garthwaite on 21 November 2022, 16:56
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by Sean Nash on 21 November 2022, 15:59 
https://devapps.diality.us/cru/DG-DEN-14000-1#c15007

  Add extra blank line here.

  Reply by Dara Navaei on 21 November 2022, 16:41
  > Done.

    Reply by Sean Nash on 21 November 2022, 17:17
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 21 November 2022, 16:03 
https://devapps.diality.us/cru/DG-DEN-14000-1#c15009

  This is a normal message - should be up above the test (dialin)
  messages.

  Reply by Dara Navaei on 21 November 2022, 16:42
  > Done.

    Reply by Sean Nash on 21 November 2022, 17:19
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14000-1 https://devapps.diality.us/cru/DG-DEN-14000-1

Title: DG-DEN-14000_SW Dev Sprint 80 Darren
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     wbracken
     Michael Garthwaite
     jtaylor