This is a list of all comments for DG-DEN-14101-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeGenIdle.c
Revision Comment by Sean Nash on 29 December 2022, 09:58 
https://devapps.diality.us/cru/DG-DEN-14101-1#c15791

  Fix indents.  Consider using /// comment above this declaration
  instead of inline ///< comment at end.

  Reply by Dara Navaei on 02 January 2023, 16:44
  > Done.

    Reply by Sean Nash on 03 January 2023, 08:50
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 29 December 2022, 10:00 
https://devapps.diality.us/cru/DG-DEN-14101-1#c15792

  Remove extra blank line.

  Reply by Dara Navaei on 02 January 2023, 16:45
  > Done.

    Reply by Sean Nash on 03 January 2023, 08:45
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 29 December 2022, 12:34 
https://devapps.diality.us/cru/DG-DEN-14101-1#c15806

  Add dataPublishCounter, genIdleDataPublicationInterval,
  handleBadFillFlag, badFillState, targetFillVolumeML.

  Reply by Dara Navaei on 02 January 2023, 16:46
  > Done

    Reply by wbracken on 02 January 2023, 17:14
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DrainPump.c
Revision Comment by Sean Nash on 29 December 2022, 09:58 
https://devapps.diality.us/cru/DG-DEN-14101-1#c15790

  Remove extra blank line.

  Reply by Dara Navaei on 02 January 2023, 16:32
  > Done.

    Reply by Sean Nash on 03 January 2023, 08:47
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14101-1 https://devapps.diality.us/cru/DG-DEN-14101-1

Title: DG-DEN-14101_SW S82 MG Dial 179 Dial 18
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (5 active, 1 completed*)
     Sean Nash   (*)
     wbracken
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe