This is a list of all comments for DG-DEN-14175-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Valves.c
Revision Comment by wbracken on 31 October 2022, 14:00 
https://devapps.diality.us/cru/DG-DEN-14175-1#c14705

  Where is valveSensedStates being updated?

  Reply by Dara Navaei on 03 November 2022, 09:54
  > No, it should be removed.

    Reply by wbracken on 03 November 2022, 10:37
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by wbracken on 28 October 2022, 11:58 
https://devapps.diality.us/cru/DG-DEN-14175-1#c14664

  Not clear this needs to be done.  I believe is properly handled
  in heaters when you get a temperature value and configured for
  V3.

  Reply by Dara Navaei on 03 November 2022, 09:56
  > This is done to get an average of the fill temperature as
  > well as the last fill temperature prior to tranistioning to
  > Gen Idle. These values are used for the next estimation and
  > are different from the heaters driver.

    Reply by wbracken on 03 November 2022, 10:32
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Controllers/TemperatureSensors.c
Revision Comment by wbracken on 31 October 2022, 13:53 
https://devapps.diality.us/cru/DG-DEN-14175-1#c14704

  Remove comment.

  Reply by Dara Navaei on 03 November 2022, 09:55
  > Done.

    Reply by wbracken on 03 November 2022, 10:29
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Services/FPGA.c
Revision Comment by wbracken on 09 November 2022, 15:05 
https://devapps.diality.us/cru/DG-DEN-14175-1#c14845

  Isn't fpgaSensorReadings an input?

  Reply by Dara Navaei on 10 November 2022, 09:07
  > Done.

    Reply by wbracken on 10 November 2022, 10:19
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeHeatDisinfect.c
Revision Comment by Sean Nash on 09 November 2022, 14:23 
https://devapps.diality.us/cru/DG-DEN-14175-1#c14844

  Restore or remove.

  Reply by Dara Navaei on 10 November 2022, 09:08
  > Done.

    Reply by Sean Nash on 10 November 2022, 10:04
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14175-1 https://devapps.diality.us/cru/DG-DEN-14175-1

Title: DG-DEN-14175_DG HD Dev HD DG Dvt Update Part 5
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Darren Cox