This is a list of all comments for DG-DEN-14237-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeHeatDisinfect.c
Revision Comment by Dara Navaei on 03 November 2022, 13:37 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14724

  This flag also should be removed.

  Reply by wbracken on 03 November 2022, 14:05
  > Removed

    Reply by Dara Navaei on 03 November 2022, 14:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:37 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14723

  Can we just remove these?

  Reply by Sean Nash on 04 November 2022, 11:10
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:39 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14728

  Remove this flag.

  Reply by wbracken on 03 November 2022, 14:07
  > Removed

    Reply by Sean Nash on 04 November 2022, 11:10
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:37 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14725

  Can we just remove this code?

  Reply by wbracken on 03 November 2022, 14:07
  > Removed

    Reply by Sean Nash on 04 November 2022, 11:11
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:40 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14729

  Remove TRUE case.  Just need the else now.

  Reply by wbracken on 03 November 2022, 14:04
  > Removed

    Reply by Sean Nash on 04 November 2022, 11:11
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:40 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14730

  Remove the TRUE case.  Just need the else now.

  Reply by wbracken on 03 November 2022, 14:03
  > Removed

    Reply by Sean Nash on 04 November 2022, 11:11
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:37 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14726

  Can we remove this code?

  Reply by wbracken on 03 November 2022, 14:03
  > Removed

    Reply by Sean Nash on 04 November 2022, 11:12
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:38 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14727

  Let's remove this code.

  Reply by wbracken on 03 November 2022, 14:04
  > Removed

    Reply by Sean Nash on 04 November 2022, 11:12
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 03 November 2022, 13:44 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14735

  Remove references to this flag.

  Reply by wbracken on 03 November 2022, 14:02
  > Removed.  Intended to remove all along.

    Reply by Sean Nash on 04 November 2022, 11:12
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Dara Navaei on 03 November 2022, 13:41 
https://devapps.diality.us/cru/DG-DEN-14237-1#c14732

  This function will still override if there any alarms. Are we
  going to change the order of status report?

  Reply by wbracken on 03 November 2022, 14:06
  > This else has been removed

    Reply by Dara Navaei on 03 November 2022, 15:30
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14237-1 https://devapps.diality.us/cru/DG-DEN-14237-1

Title: DG-DEN-14237_Remove Heat Disinfect Rinse States
Statement of Objectives:


State: Closed

Summary: 

Author: wbracken
Moderator: wbracken
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     Michael Garthwaite
     Darren Cox