This is a list of all comments for DG-DEN-14253-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/FlowSensors.c
Revision Comment by Sean Nash on 02 December 2022, 16:43 
https://devapps.diality.us/cru/DG-DEN-14253-1#c15108

  For both sensors, the .data should only be set once to final
  value.  Use a temporary local variable until it's ready.

  Reply by Dara Navaei on 02 December 2022, 17:50
  > Done.

    Reply by Sean Nash on 05 December 2022, 09:43
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Heaters.c
Revision Comment by Sean Nash on 02 December 2022, 16:49 
https://devapps.diality.us/cru/DG-DEN-14253-1#c15109

  Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE :
  TRUE );

  Reply by Dara Navaei on 02 December 2022, 17:43
  > Done.

    Reply by Sean Nash on 05 December 2022, 09:42
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14253-1 https://devapps.diality.us/cru/DG-DEN-14253-1

Title: DG-DEN-14253_Dialysate Flow Too Low Alarm Occurs AT 100 ML Min
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 1 completed*)
     Sean Nash   (*)
     wbracken
     Michael Garthwaite
     Darren Cox
     jtaylor