This is a list of all comments for DG-DEN-14307-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/ConcentratePumps.c Revision Comment by wbracken on 19 December 2022, 14:12 https://devapps.diality.us/cru/DG-DEN-14307-1#c15265 Update function header. Reply by Dara Navaei on 21 December 2022, 11:16 > Done Reply by wbracken on 21 December 2022, 12:05 > RESOLVED IN CODEWALKTHROUGH. Revision Comment by Sean Nash on 20 December 2022, 15:26 https://devapps.diality.us/cru/DG-DEN-14307-1#c15513 Add a comment to explain why this is here. Reply by Dara Navaei on 21 December 2022, 10:57 > Done Reply by Sean Nash on 21 December 2022, 11:21 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 19 December 2022, 14:15 https://devapps.diality.us/cru/DG-DEN-14307-1#c15266 Update function header. Reply by Dara Navaei on 21 December 2022, 11:15 > Done Reply by wbracken on 21 December 2022, 12:06 > RESOLVED IN CODEWALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Pressures.c Revision Comment by Sean Nash on 20 December 2022, 15:29 https://devapps.diality.us/cru/DG-DEN-14307-1#c15517 Need a default case with s/w fault. Reply by Dara Navaei on 21 December 2022, 10:55 > Done Reply by Sean Nash on 21 December 2022, 11:23 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeFlush.c Revision Comment by wbracken on 19 December 2022, 14:23 https://devapps.diality.us/cru/DG-DEN-14307-1#c15267 Alignment Reply by Dara Navaei on 21 December 2022, 11:13 > Done Reply by wbracken on 21 December 2022, 12:09 > RESOLVED IN CODEWALKTHROUGH. Revision Comment by wbracken on 19 December 2022, 14:24 https://devapps.diality.us/cru/DG-DEN-14307-1#c15268 Update function header. Reply by Dara Navaei on 21 December 2022, 11:12 > Done Reply by wbracken on 21 December 2022, 12:12 > Should add alarmDetectedPendingTrigger and preFlushState. Reply by Dara Navaei on 21 December 2022, 13:04 > Done Reply by wbracken on 21 December 2022, 14:44 > RESOLVED IN CODEWALKTHROUGH. Revision Comment by wbracken on 19 December 2022, 14:27 https://devapps.diality.us/cru/DG-DEN-14307-1#c15269 Update function header. Reply by Dara Navaei on 21 December 2022, 11:12 > The function is up to date. Reply by wbracken on 21 December 2022, 12:13 > RESOLVED IN CODEWALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeHeatDisinfect.c Revision Comment by Sean Nash on 20 December 2022, 16:18 https://devapps.diality.us/cru/DG-DEN-14307-1#c15535 This kind of temporary test change should probably not be committed. Just do locally in lab so reviewers don't see it and no chance that it stays this way. Reply by Dara Navaei on 21 December 2022, 10:53 > Done Reply by Sean Nash on 21 December 2022, 11:31 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 December 2022, 16:21 https://devapps.diality.us/cru/DG-DEN-14307-1#c15536 Remove blank line. Reply by Dara Navaei on 21 December 2022, 10:53 > Done Reply by Sean Nash on 21 December 2022, 11:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 December 2022, 16:23 https://devapps.diality.us/cru/DG-DEN-14307-1#c15537 Remove blank lines. If nothing in else, remove else. Reply by Dara Navaei on 21 December 2022, 10:52 > Done Reply by Sean Nash on 21 December 2022, 11:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by wbracken on 21 December 2022, 14:52 https://devapps.diality.us/cru/DG-DEN-14307-1#c15705 Add concCap and diaCap to header. Reply by Dara Navaei on 21 December 2022, 14:55 > These two variables are local. Reply by wbracken on 21 December 2022, 14:56 > RESOLVED IN CODE WALKTRHOUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by wbracken on 19 December 2022, 14:55 https://devapps.diality.us/cru/DG-DEN-14307-1#c15272 Should this be removed? Reply by Dara Navaei on 21 December 2022, 10:58 > No, it was removed by accident. Reply by wbracken on 21 December 2022, 12:10 > RESOLVED IN CODEWALKTHROUGH. Revision Comment by Sean Nash on 20 December 2022, 16:57 https://devapps.diality.us/cru/DG-DEN-14307-1#c15547 This message clearly has a payload - we should check payload length to be whatever it is. Reply by Dara Navaei on 21 December 2022, 10:48 > Done. Reply by Sean Nash on 21 December 2022, 11:36 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/ConductivitySensors.c Revision Comment by Sean Nash on 20 December 2022, 15:27 https://devapps.diality.us/cru/DG-DEN-14307-1#c15514 Alignment. Reply by Sean Nash on 21 December 2022, 13:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 December 2022, 15:28 https://devapps.diality.us/cru/DG-DEN-14307-1#c15516 Need a default case w/ s/w fault. Reply by Dara Navaei on 21 December 2022, 10:55 > Done Reply by Sean Nash on 21 December 2022, 11:22 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/TemperatureSensors.c Revision Comment by Sean Nash on 20 December 2022, 15:33 https://devapps.diality.us/cru/DG-DEN-14307-1#c15519 Need default case with s/w fault. Reply by Dara Navaei on 21 December 2022, 10:54 > Done Reply by Sean Nash on 21 December 2022, 11:24 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/AlarmMgmt.c Revision Comment by Sean Nash on 20 December 2022, 16:44 https://devapps.diality.us/cru/DG-DEN-14307-1#c15542 Need a default case w/ comment stating status already set to TRUE for all other modes. Reply by Dara Navaei on 21 December 2022, 10:49 > Done Reply by Sean Nash on 21 December 2022, 11:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/OperationModes.c Revision Comment by Sean Nash on 20 December 2022, 16:41 https://devapps.diality.us/cru/DG-DEN-14307-1#c15539 Should not be able to transition from fault to either new mode. Reply by Dara Navaei on 21 December 2022, 10:52 > Done Reply by Sean Nash on 21 December 2022, 11:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 December 2022, 16:42 https://devapps.diality.us/cru/DG-DEN-14307-1#c15540 Should not be able to transition from heat disinfect cool to chem disinfect cool. Reply by Dara Navaei on 21 December 2022, 10:51 > Done Reply by Sean Nash on 21 December 2022, 11:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 20 December 2022, 16:43 https://devapps.diality.us/cru/DG-DEN-14307-1#c15541 Remove extra blank line. Reply by Dara Navaei on 21 December 2022, 10:50 > Done Reply by Sean Nash on 21 December 2022, 11:34 > RESOLVED in CODE WALKTHROUGH. --- ID: DG-DEN-14307-1 https://devapps.diality.us/cru/DG-DEN-14307-1 Title: DG-DEN-14307_DG HD Dev HD DG Dvt Update Part 6 Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (3 active, 2 completed*) Sean Nash (*) wbracken (*) Michael Garthwaite Darren Cox jtaylor