This is a list of all comments for DG-DEN-14497-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/ModeChemicalDisinfect.c Revision Comment by Sean Nash on 10 January 2023, 18:02 https://devapps.diality.us/cru/DG-DEN-14497-1#c15881 Remove extra blank line. Reply by Dara Navaei on 11 January 2023, 09:38 > Done Reply by Sean Nash on 11 January 2023, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:03 https://devapps.diality.us/cru/DG-DEN-14497-1#c15882 Keep a blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:38 > Done Reply by Sean Nash on 11 January 2023, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:03 https://devapps.diality.us/cru/DG-DEN-14497-1#c15883 Keep a blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:38 > Done Reply by Sean Nash on 11 January 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:04 https://devapps.diality.us/cru/DG-DEN-14497-1#c15884 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:37 > Done Reply by Sean Nash on 11 January 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:04 https://devapps.diality.us/cru/DG-DEN-14497-1#c15885 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:37 > Done Reply by Sean Nash on 11 January 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:05 https://devapps.diality.us/cru/DG-DEN-14497-1#c15886 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:37 > Done Reply by Sean Nash on 11 January 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:06 https://devapps.diality.us/cru/DG-DEN-14497-1#c15887 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:37 > Done Reply by Sean Nash on 11 January 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:06 https://devapps.diality.us/cru/DG-DEN-14497-1#c15888 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:36 > Done Reply by Sean Nash on 11 January 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DrainPump.c Revision Comment by Sean Nash on 10 January 2023, 17:56 https://devapps.diality.us/cru/DG-DEN-14497-1#c15878 What is difference between P coefficient and P term a few lines above? Reply by Dara Navaei on 11 January 2023, 10:04 > Made them different. Reply by Sean Nash on 11 January 2023, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 01 January 2023, 22:55 https://devapps.diality.us/cru/DG-DEN-14497-1#c15807 Add to header and alignment. Reply by Dara Navaei on 11 January 2023, 10:32 > Done Reply by wbracken on 11 January 2023, 11:24 > RESOLVED IN CODE WALKTHROUGH. Revision Comment by wbracken on 01 January 2023, 22:56 https://devapps.diality.us/cru/DG-DEN-14497-1#c15808 Alignment. Reply by Dara Navaei on 11 January 2023, 10:30 > It is aligned. Reply by wbracken on 11 January 2023, 11:23 > RESOLVED IN CODE WALKTHROUGH. Revision Comment by wbracken on 01 January 2023, 22:57 https://devapps.diality.us/cru/DG-DEN-14497-1#c15809 Header needs to be updated. Reply by Dara Navaei on 11 January 2023, 10:30 > Done Reply by wbracken on 11 January 2023, 11:23 > RESOLVED IN CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Heaters.c Revision Comment by wbracken on 01 January 2023, 23:05 https://devapps.diality.us/cru/DG-DEN-14497-1#c15810 Add heaterStatus to header. Reply by wbracken on 11 January 2023, 13:10 > RESOLVED IN CODEWALKTHROUGH. Revision Comment by wbracken on 01 January 2023, 23:07 https://devapps.diality.us/cru/DG-DEN-14497-1#c15811 The description seems to be missing a few words. Reply by Dara Navaei on 11 January 2023, 10:27 > Done Reply by wbracken on 11 January 2023, 11:22 > RESOLVED IN CODE WALKTHROUGH. Revision Comment by Sean Nash on 05 January 2023, 11:38 https://devapps.diality.us/cru/DG-DEN-14497-1#c15842 Use get function for override. Reply by Dara Navaei on 11 January 2023, 10:08 > Done Reply by Sean Nash on 11 January 2023, 10:41 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/ROPump.c Revision Comment by wbracken on 01 January 2023, 23:11 https://devapps.diality.us/cru/DG-DEN-14497-1#c15812 Should be removed? Reply by Dara Navaei on 11 January 2023, 10:26 > Done Reply by wbracken on 11 January 2023, 11:21 > RESOLVED IN CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeHeatDisinfect.c Revision Comment by wbracken on 04 January 2023, 12:01 https://devapps.diality.us/cru/DG-DEN-14497-1#c15838 Assume this is for testing? Reply by Dara Navaei on 11 January 2023, 10:25 > Yes, it has been updated. Reply by wbracken on 11 January 2023, 11:20 > RESOLVED IN CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:11 https://devapps.diality.us/cru/DG-DEN-14497-1#c15893 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:31 > Done Reply by Sean Nash on 11 January 2023, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:13 https://devapps.diality.us/cru/DG-DEN-14497-1#c15894 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:28 > Done Reply by Sean Nash on 11 January 2023, 10:37 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/ConductivitySensors.c Revision Comment by Sean Nash on 10 January 2023, 17:55 https://devapps.diality.us/cru/DG-DEN-14497-1#c15877 Does this alarm not have different clear threshold in cleaning modes? Reply by Dara Navaei on 11 January 2023, 10:04 > No, the thresholds are the same except the cleaning modes > fault. Reply by Sean Nash on 11 January 2023, 10:06 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Pressures.c Revision Comment by Sean Nash on 10 January 2023, 17:58 https://devapps.diality.us/cru/DG-DEN-14497-1#c15879 Do we not have different clear thresholds while in cleaning modes? Reply by Dara Navaei on 11 January 2023, 09:40 > No, the thresholds are the same except in the cleaning modes > we fault. Reply by Sean Nash on 11 January 2023, 10:19 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/TemperatureSensors.c Revision Comment by Sean Nash on 10 January 2023, 18:01 https://devapps.diality.us/cru/DG-DEN-14497-1#c15880 Do we not have different clear thresholds while in cleaning modes? Reply by Dara Navaei on 11 January 2023, 09:39 > No, the thresholds are the same except in the cleaning modes > we fault and in the treatment modes we recover if possible. Reply by Sean Nash on 11 January 2023, 10:00 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeChemicalDisinfectFlush.c Revision Comment by Sean Nash on 10 January 2023, 18:08 https://devapps.diality.us/cru/DG-DEN-14497-1#c15889 Keep blank line between declarations and code. Reply by Sean Nash on 11 January 2023, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:10 https://devapps.diality.us/cru/DG-DEN-14497-1#c15890 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:34 > Done Reply by Sean Nash on 11 January 2023, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:10 https://devapps.diality.us/cru/DG-DEN-14497-1#c15891 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:34 > Done Reply by Sean Nash on 11 January 2023, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 January 2023, 18:10 https://devapps.diality.us/cru/DG-DEN-14497-1#c15892 Keep blank line between declarations and code. Reply by Dara Navaei on 11 January 2023, 09:33 > Done Reply by Sean Nash on 11 January 2023, 10:38 > RESOLVED in CODE WALKTHROUGH. --- ID: DG-DEN-14497-1 https://devapps.diality.us/cru/DG-DEN-14497-1 Title: DG-DEN-14497_DG HD Dev HD DG Dvt Update Part 7 Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (5 active, 1 completed*) Sean Nash (*) Michael Garthwaite wbracken Darren Cox jtaylor Steve Jarpe