This is a list of all comments for DG-DEN-14547-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Sean Nash on 04 February 2023, 14:42 
https://devapps.diality.us/cru/DG-DEN-14547-1#c16365

  Add currentMode, currentSubMode to inputs and outputs

  Reply by Michael Garthwaite on 06 February 2023, 13:41
  > Fixed. Thanks!

    Reply by Sean Nash on 06 February 2023, 14:14
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 04 February 2023, 14:36 
https://devapps.diality.us/cru/DG-DEN-14547-1#c16360

  Remove blank lines.

  Reply by Michael Garthwaite on 06 February 2023, 13:41
  > Fixed. Thanks!

    Reply by Sean Nash on 06 February 2023, 14:14
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 02 February 2023, 14:13 
https://devapps.diality.us/cru/DG-DEN-14547-1#c16303

  Remove blank line

  Reply by Michael Garthwaite on 06 February 2023, 13:41
  > Fixed. Thanks!

    Reply by wbracken on 06 February 2023, 13:47
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 04 February 2023, 14:40 
https://devapps.diality.us/cru/DG-DEN-14547-1#c16362

  Should currentSubMode be assigned to return value here?

  Reply by Michael Garthwaite on 06 February 2023, 13:34
  > transitionToNewOperationMode() is currently void. This would
  > have to change to returning the submode enum. This was an
  > issue found in testing the events that we miss the event
  > transition from going to new modes and needed the code change
  > down at line ~380.
  > 
  > Do we want to change transitionToNewOperationMode() to return
  > sub mode?

    Reply by Sean Nash on 06 February 2023, 14:13
    > You're right.  
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 04 February 2023, 14:42 
https://devapps.diality.us/cru/DG-DEN-14547-1#c16364

  currentSubMode is an input now.

  Reply by Michael Garthwaite on 06 February 2023, 13:41
  > Fixed. Thanks!

    Reply by Sean Nash on 06 February 2023, 14:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 04 February 2023, 14:38 
https://devapps.diality.us/cru/DG-DEN-14547-1#c16361

  Move blank line from before to after declaration.

  Reply by Michael Garthwaite on 06 February 2023, 13:41
  > Fixed. Thanks!

    Reply by Sean Nash on 06 February 2023, 14:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 04 February 2023, 14:41 
https://devapps.diality.us/cru/DG-DEN-14547-1#c16363

  Restore this blank line.

  Reply by Michael Garthwaite on 06 February 2023, 13:40
  > Fixed. Thanks!

    Reply by Sean Nash on 06 February 2023, 14:12
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14547-1 https://devapps.diality.us/cru/DG-DEN-14547-1

Title: DG-DEN-14547_Incorrect DG Event
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe