This is a list of all comments for DG-DEN-14607-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Pressures.c
Revision Comment by Sean Nash on 21 January 2023, 16:19 
https://devapps.diality.us/cru/DG-DEN-14607-1#c16206

  Why is there an exception for overrides?  Override is gauge,
  right?  So we should always add baro to get absolute here,
  right?

  Reply by Dara Navaei on 23 January 2023, 08:56
  > I removed the override.

    Reply by Sean Nash on 23 January 2023, 09:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by Sean Nash on 21 January 2023, 16:20 
https://devapps.diality.us/cru/DG-DEN-14607-1#c16207

  Remove blank line.

  Reply by Dara Navaei on 23 January 2023, 08:57
  > Done

    Reply by Sean Nash on 23 January 2023, 09:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: AlarmDefs.h
Revision Comment by wbracken on 22 January 2023, 21:21 
https://devapps.diality.us/cru/DG-DEN-14607-1#c16214

  AlarmDefs changes need to be reconciled with the DG SRS

  Reply by Dara Navaei on 23 January 2023, 08:58
  > They have been aligned.

    Reply by wbracken on 23 January 2023, 10:00
    > RESOLVED IN CODE WALKTHROUGH


---

ID: DG-DEN-14607-1 https://devapps.diality.us/cru/DG-DEN-14607-1

Title: DG-DEN-14607_Alarm 89 And 198 Trigger During Priming
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Darren Cox
     jtaylor
     Steve Jarpe